fs: fix validation of negative offset to avoid abort#38421
Closed
jasnell wants to merge 2 commits intonodejs:masterfrom
Closed
fs: fix validation of negative offset to avoid abort#38421jasnell wants to merge 2 commits intonodejs:masterfrom
jasnell wants to merge 2 commits intonodejs:masterfrom
Conversation
github-actions
bot
added
fs
This comment has been minimized.
This comment has been minimized.
BridgeAR
approved these changes
Apr 26, 2021
jasnell
added
author ready
This comment has been minimized.
This comment has been minimized.
Contributor
|
I think that the real issue is only in write as negative offset is already checked in Note that the check for fs.open('./tst/some-file.file', 'w+', (err, fd) => {
fs.write(fd, Buffer.from('text'), 0, -10, (err) => {
console.log(err);
});
}) |
jasnell
removed
the
author ready
Member
Author
Yeah, I modified the reads here just for consistency.
Sigh. Yeah, missed that. |
Fixes: nodejs#24640 Signed-off-by: James M Snell <[email protected]>
jasnell
force-pushed
the
fix-fs-write-abort-on-negative-offset
branch
from
bce3d67 to
837137f
Compare
Linkgoron
reviewed
Apr 27, 2021
Linkgoron
approved these changes
Apr 27, 2021
RaisinTen
reviewed
Apr 27, 2021
Member
RaisinTen
left a comment
RaisinTen
left a comment
There was a problem hiding this comment.
Would it make sense to also move validateInteger(offset, 'offset', 0); into validateOffsetLengthRead and validateOffsetLengthWrite? That way, we could have just one validation for each field.
Co-authored-by: linkgoron <[email protected]>
Member
Author
Perhaps, but let's save that for a separate PR. |
RaisinTen
approved these changes
Apr 27, 2021
RaisinTen
added
the
author ready
Member
Author
|
Landed in 4af15df |
jasnell
added a commit
that referenced
this pull request
Apr 28, 2021
Fixes: #24640 Signed-off-by: James M Snell <[email protected]> PR-URL: #38421 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Nitzan Uziely <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
targos
pushed a commit
that referenced
this pull request
Apr 29, 2021
Fixes: #24640 Signed-off-by: James M Snell <[email protected]> PR-URL: #38421 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Nitzan Uziely <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 30, 2021
Fixes: #24640 Signed-off-by: James M Snell <[email protected]> PR-URL: #38421 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Nitzan Uziely <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
Fixes: #24640 Signed-off-by: James M Snell <[email protected]> PR-URL: #38421 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Nitzan Uziely <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
Fixes: #24640 Signed-off-by: James M Snell <[email protected]> PR-URL: #38421 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Nitzan Uziely <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
Fixes: #24640 Signed-off-by: James M Snell <[email protected]> PR-URL: #38421 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Nitzan Uziely <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: James M Snell [email protected]
Fixes: #24640