Skip to content

Comments

debugger: fix auto-fixable lint issues in inspect library code#38411

Merged
Trott merged 2 commits intonodejs:masterfrom
Trott:inspect-lint
Apr 28, 2021
Merged

debugger: fix auto-fixable lint issues in inspect library code#38411
Trott merged 2 commits intonodejs:masterfrom
Trott:inspect-lint

Conversation

@Trott
Copy link
Member

@Trott Trott commented Apr 26, 2021

No description provided.

@github-actions github-actions bot added inspector Issues and PRs related to the V8 inspector protocol needs-ci PRs that need a full CI run. labels Apr 26, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 27, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/37762/

@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 27, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 28, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/37769/

Trott added 2 commits April 28, 2021 07:02
@Trott
debugger: apply automatic lint fixes for _inspect.js
ea47bd2 
For issues that ESLint can fix automatically, fix them.

PR-URL: nodejs#38411
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@Trott
debugger: apply automatic lint fixes for inspect_repl.js
bdb6c59 
For issues that ESLint can fix automatically, fix them.

PR-URL: nodejs#38411
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@Trott
Copy link
Member Author

Trott commented Apr 28, 2021

Landed in 3d070d0...bdb6c59

@Trott Trott merged commit bdb6c59 into nodejs:master Apr 28, 2021
@Trott Trott deleted the inspect-lint branch April 28, 2021 14:03
targos pushed a commit that referenced this pull request Apr 29, 2021
@Trott @targos
debugger: apply automatic lint fixes for _inspect.js
b884ea7 
For issues that ESLint can fix automatically, fix them.

PR-URL: #38411
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
targos pushed a commit that referenced this pull request Apr 29, 2021
@Trott @targos
debugger: apply automatic lint fixes for inspect_repl.js
a0c566f 
For issues that ESLint can fix automatically, fix them.

PR-URL: #38411
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@targos targos mentioned this pull request May 3, 2021
Merged
@Trott Trott mentioned this pull request Jul 16, 2021
Closed
@Trott
Copy link
Member Author

Trott commented Jul 19, 2021

@targos I don't think this should be backport-blocked. I believe this will cherry-pick cleanly to v14.x-staging and I don't think it will cause any problems. Am I wrong? (With I think only one exception, these are all space/formatting changes.)

@Trott
Copy link
Member Author

Trott commented Jul 19, 2021

@targos I don't think this should be backport-blocked. I believe this will cherry-pick cleanly to v14.x-staging and I don't think it will cause any problems. Am I wrong? (With I think only one exception, these are all space/formatting changes.)

Oh, wait, that label was added weeks ago. Hey, @richardlau, this one should be cherry-pickable at this point, right? I know the subsequent ones I suggested cherry-picking used timers/promises but I think this one should be OK?

@targos
Copy link
Member

targos commented Jul 19, 2021

It didn't land cleanly when I added the label, but it's possible it does now. I just removed the label.

aduh95 pushed a commit to aduh95/node that referenced this pull request Jul 19, 2021
@Trott @aduh95
debugger: apply automatic lint fixes for _inspect.js
cd5bb0e 
For issues that ESLint can fix automatically, fix them.

PR-URL: nodejs#38411
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Jul 19, 2021
@Trott @aduh95
debugger: apply automatic lint fixes for inspect_repl.js
0384dd4 
For issues that ESLint can fix automatically, fix them.

PR-URL: nodejs#38411
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
richardlau pushed a commit that referenced this pull request Jul 19, 2021
@Trott @richardlau
debugger: apply automatic lint fixes for _inspect.js
3b59fdb 
For issues that ESLint can fix automatically, fix them.

PR-URL: #38411
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
richardlau pushed a commit that referenced this pull request Jul 19, 2021
@Trott @richardlau
debugger: apply automatic lint fixes for inspect_repl.js
c3d4968 
For issues that ESLint can fix automatically, fix them.

PR-URL: #38411
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@richardlau
Copy link
Member

richardlau commented Jul 19, 2021

This one cherry-picks cleanly onto v14.x-staging.

@richardlau richardlau mentioned this pull request Jul 19, 2021
Closed
richardlau pushed a commit that referenced this pull request Jul 20, 2021
@Trott @richardlau
debugger: apply automatic lint fixes for _inspect.js
8dd1f70 
For issues that ESLint can fix automatically, fix them.

PR-URL: #38411
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
@Trott @richardlau
debugger: apply automatic lint fixes for inspect_repl.js
61da371 
For issues that ESLint can fix automatically, fix them.

PR-URL: #38411
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@richardlau richardlau mentioned this pull request Jul 20, 2021
Merged
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@Trott @foxxyz
debugger: apply automatic lint fixes for _inspect.js
518eb74 
For issues that ESLint can fix automatically, fix them.

PR-URL: nodejs#38411
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@Trott @foxxyz
debugger: apply automatic lint fixes for inspect_repl.js
7acd247 
For issues that ESLint can fix automatically, fix them.

PR-URL: nodejs#38411
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. inspector Issues and PRs related to the V8 inspector protocol needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@Trott @nodejs-github-bot @targos @richardlau @jasnell @lpinca @cjihrig @RaisinTen