doc: recommend queueMicrotask over process.nextTick#37484
Closed
jasnell wants to merge 1 commit intonodejs:masterfrom
Closed
doc: recommend queueMicrotask over process.nextTick#37484jasnell wants to merge 1 commit intonodejs:masterfrom
jasnell wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
doc
devsnek
approved these changes
Feb 22, 2021
mscdex
reviewed
Feb 23, 2021
Contributor
|
I think one obvious (and probably note-worthy) incompatibility compared to |
Member
Author
Good point and definitely worth adding. |
Contributor
|
Should |
ronag
reviewed
Feb 23, 2021
We likely cannot ever deprecate process.nextTick, but we can start steering people towards queueMicrotask for most cases. Signed-off-by: James M Snell <[email protected]> Fixes: nodejs#36870
jasnell
force-pushed
the
recommend-queuemicrotask
branch
from
e4c86c3 to
02f32c6
Compare
Member
Author
|
@Delapouite ... yes, but that's a separate change. |
jasnell
added
the
author ready
ronag
added a commit
to nodejs/undici
that referenced
this pull request
Feb 24, 2021
Fixes: #562 Refs: nodejs/node#37484
marsonya
approved these changes
Feb 24, 2021
ronag
approved these changes
Feb 25, 2021
Member
Author
|
Landed in ee6c467 |
jasnell
added a commit
that referenced
this pull request
Feb 25, 2021
We likely cannot ever deprecate process.nextTick, but we can start steering people towards queueMicrotask for most cases. Signed-off-by: James M Snell <[email protected]> Fixes: #36870 PR-URL: #37484 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Robert Nagy <[email protected]>
targos
pushed a commit
that referenced
this pull request
Feb 28, 2021
We likely cannot ever deprecate process.nextTick, but we can start steering people towards queueMicrotask for most cases. Signed-off-by: James M Snell <[email protected]> Fixes: #36870 PR-URL: #37484 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Robert Nagy <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
We likely cannot ever deprecate process.nextTick, but we can start steering people towards queueMicrotask for most cases. Signed-off-by: James M Snell <[email protected]> Fixes: #36870 PR-URL: #37484 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Robert Nagy <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We likely cannot ever deprecate process.nextTick, but we can start
steering people towards queueMicrotask for most cases.
Signed-off-by: James M Snell [email protected]
Fixes: #36870