test: fix test-memory-usage.js for IBMi #36758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
IBMi CI on master (should fail): https://ci.nodejs.org/job/node-test-commit-ibmi/210/ IBMi CI this PR (should pass): https://ci.nodejs.org/job/node-test-commit-ibmi/212/ |
github-actions
bot
removed
the
request-ci
richardlau
approved these changes
Jan 3, 2021
Member
|
cc @nodejs/platform-ibmi |
gireeshpunathil
approved these changes
Jan 4, 2021
watilde
approved these changes
Jan 4, 2021
Newly added process.memoryUsage.rss() will presumably return 0 on IBMi the same way process.memoryUsage().rss does. Allow IBMi to skip the new assertion. The test was using a mix of `assert()` and `assert.ok()`. This change makes it consistently use `assert.ok()`. PR-URL: nodejs#36758 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Member
Author
|
Landed in 6a5d628 |
danielleadams
pushed a commit
that referenced
this pull request
Jan 12, 2021
Newly added process.memoryUsage.rss() will presumably return 0 on IBMi the same way process.memoryUsage().rss does. Allow IBMi to skip the new assertion. The test was using a mix of `assert()` and `assert.ok()`. This change makes it consistently use `assert.ok()`. PR-URL: #36758 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
Aug 8, 2021
Newly added process.memoryUsage.rss() will presumably return 0 on IBMi the same way process.memoryUsage().rss does. Allow IBMi to skip the new assertion. The test was using a mix of `assert()` and `assert.ok()`. This change makes it consistently use `assert.ok()`. PR-URL: #36758 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Aug 12, 2021
Newly added process.memoryUsage.rss() will presumably return 0 on IBMi the same way process.memoryUsage().rss does. Allow IBMi to skip the new assertion. The test was using a mix of `assert()` and `assert.ok()`. This change makes it consistently use `assert.ok()`. PR-URL: #36758 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Aug 31, 2021
Newly added process.memoryUsage.rss() will presumably return 0 on IBMi the same way process.memoryUsage().rss does. Allow IBMi to skip the new assertion. The test was using a mix of `assert()` and `assert.ok()`. This change makes it consistently use `assert.ok()`. PR-URL: #36758 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
foxxyz
pushed a commit
to foxxyz/node
that referenced
this pull request
Oct 18, 2021
Newly added process.memoryUsage.rss() will presumably return 0 on IBMi the same way process.memoryUsage().rss does. Allow IBMi to skip the new assertion. The test was using a mix of `assert()` and `assert.ok()`. This change makes it consistently use `assert.ok()`. PR-URL: nodejs#36758 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newly added process.memoryUsage.rss() will presumably return 0 on IBMi
the same way process.memoryUsage().rss does. Allow IBMi to skip the new
assertion.
The test was using a mix of
assert()andassert.ok(). This changemakes it consistently use
assert.ok().Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes