Conversation
|
Review requested:
|
nodejs-github-bot
added
the
c++
|
Are the n-api changes here intentional? |
doc/guides/collaborator-guide.md
Outdated
There was a problem hiding this comment.
Link to the repository? Or should we keep it without a link on purpose?
Also, I assume it will be a repo on nodejs-private?
There was a problem hiding this comment.
I've not created the repo yet, but a link makes sense. It should only be accessible to those who have access to private repos within the org
There was a problem hiding this comment.
@mmarchini added the link in the first reference, not sure if we need to make all references a link or not.
There was a problem hiding this comment.
Also, I assume it will be a repo on nodejs-private?
No, its a private repo in the nodejs org as I don't believe we can move issues across organizations.
There was a problem hiding this comment.
I see. The downside is that folks who have access to private repos in this org but not on the repo we usually use for security releases will have access to the issue. It's probably fine though, it only means some folks in moderation and CommComm will have access to the issue even when they don't have access to security release discussions (which is still better than keeping the issue public).
There was a problem hiding this comment.
Add process for handling premature disclosure of a security vulnerability in the public repos. Signed-off-by: Michael Dawson <[email protected]>
mhdawson
force-pushed
the
inadvertant-disclosure
branch
from
06b7d65 to
83c1c12
Compare
Flarna
removed
the
c++
Co-authored-by: Richard Lau <[email protected]>
Co-authored-by: Richard Lau <[email protected]>
mmarchini
left a comment
mmarchini
left a comment
There was a problem hiding this comment.
lgtm. I think we need to open a request on nodejs/admin to create the repository, correct?
Co-authored-by: mary marchini <[email protected]>
|
@mmarchini good call on creating the request in admin. Here is the list: nodejs/admin#573 |
Add process for handling premature disclosure of a security vulnerability in the public repos. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #36155 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Rich Trott <[email protected]>
|
Landed as 9cf2341 |
Add process for handling premature disclosure of a security vulnerability in the public repos. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #36155 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Add process for handling premature disclosure of a security vulnerability in the public repos. Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs#36155 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Add process for handling premature disclosure of a security vulnerability in the public repos. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #36155 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Rich Trott <[email protected]>
9 participants
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes