[v14.x backport] src: create helper for reading Uint32BE#35701
Closed
juanarbol wants to merge 1 commit intonodejs:v14.x-stagingfrom
Closed
[v14.x backport] src: create helper for reading Uint32BE#35701juanarbol wants to merge 1 commit intonodejs:v14.x-stagingfrom
juanarbol wants to merge 1 commit intonodejs:v14.x-stagingfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Fixes: nodejs#34827 Backport-PR-URL: nodejs#35701
juanarbol
force-pushed
the
backport-34944-to-14.x
branch
from
87f66b5 to
02b9af1
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
request-ci
BethGriggs
approved these changes
Dec 9, 2020
BethGriggs
pushed a commit
that referenced
this pull request
Dec 9, 2020
Fixes: #34827 Backport-PR-URL: #35701 PR-URL: #34944 Reviewed-By: Anna Henningsen <[email protected]>
Member
|
Landed in 7057d34 |
BethGriggs
pushed a commit
that referenced
this pull request
Dec 10, 2020
Fixes: #34827 Backport-PR-URL: #35701 PR-URL: #34944 Reviewed-By: Anna Henningsen <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 15, 2020
Fixes: #34827 Backport-PR-URL: #35701 PR-URL: #34944 Reviewed-By: Anna Henningsen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #34944
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes