doc: Remove reference to io.js#35618
doc: Remove reference to io.js#35618hexxdump wants to merge 1 commit intonodejs:masterfrom hexxdump:master
Conversation
nodejs-github-bot
added
doc
|
Please review |
doc/api/process.md
Outdated
There was a problem hiding this comment.
| * `name` {string} A value that will always be `'node'` for Node.js. | |
| * `name` {string} A value that will always be `'node'`. |
|
@Trott @gireeshpunathil @antsmartian @evanlucas, can these changes be merged now ? |
Signed-off-by: Hussaina Begum Nandyala <[email protected]>
|
@gireeshpunathil, incorporated the changes suggested by @Trott |
Signed-off-by: Hussaina Begum Nandyala <[email protected]> PR-URL: #35618 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
|
landed in 4079bfd . thanks for the contribution! |
|
Thanks @gireeshpunathil, Its a very small change, I'm just getting started with OSS as part of Hacktoberfest. Will it be possible to mark this issue with 'hacktoberfest' label? |
|
I don't see that label anymore! @Trott - do you know? |
|
To my knowledge, only https://github.com/nodejs/docker-node and https://github.com/nodejs/nodejs.dev are participating in Hacktoberfest. No other nodejs repos are participating (as far as I am aware). |
No issues @Trott. I submitted another PR for Hactoberfest. Happy to see my first tiny commit in nodejs. |
Signed-off-by: Hussaina Begum Nandyala <[email protected]> PR-URL: #35618 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Signed-off-by: Hussaina Begum Nandyala <[email protected]> PR-URL: nodejs#35618 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
7 participants
doc: Remove reference to io.js
io.js is outdated, hence removed reference to it from docs.
Fixes:#35580
Signed-off-by: Hussaina Begum Nandyala [email protected]
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes