Closed
Conversation
License is out of date
nodejs-github-bot
added
the
meta
Collaborator
|
Review requested:
|
aduh95
approved these changes
Oct 9, 2020
richardlau
approved these changes
Oct 9, 2020
BethGriggs
approved these changes
Oct 9, 2020
bnb
approved these changes
Oct 9, 2020
mmarchini
approved these changes
Oct 10, 2020
Contributor
|
Wondering if we can automate that with Actions somehow (either run the tool and autocommit or linter to check for changes). Linter would probably be the easiest and least disruptive approach as the linter could run only when deps/ change. |
Contributor
Author
|
Linter should be reasonably straight forward. Run the command and fail if there is a diff |
codebytere
approved these changes
Oct 10, 2020
Trott
approved these changes
Oct 10, 2020
gengjiawen
approved these changes
Oct 10, 2020
Contributor
Author
|
Landed in 708c87d |
MylesBorins
added a commit
that referenced
this pull request
Oct 12, 2020
License is out of date PR-URL: #35577 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
MylesBorins
added a commit
that referenced
this pull request
Oct 14, 2020
License is out of date PR-URL: #35577 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
Merged
Contributor
|
@MylesBorins @mmarchini you could also have it automatically PR if there is a diff with @gr2m's create-or-update-pull-request-action: https://github.com/gr2m/create-or-update-pull-request-action |
Contributor
Author
|
I won't haved time to dig into this for a bit if someone else wants to pick it up. |
Contributor
|
Already working on a PR. |
Contributor
|
holler if I can help in any way |
1 task
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
License is out of date PR-URL: nodejs#35577 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
License is out of date
Created by running
./tools/license-builder.sh