Skip to content

deps: upgrade npm to 7.0.0-rc.4#35576

Closed
MylesBorins wants to merge 1 commit intonodejs:masterfrom
MylesBorins:npm-7.0.0-rc.4
Closed

deps: upgrade npm to 7.0.0-rc.4#35576
MylesBorins wants to merge 1 commit intonodejs:masterfrom
MylesBorins:npm-7.0.0-rc.4

Conversation

@MylesBorins
Copy link
Copy Markdown
Contributor

Fixed a couple of edge cases identified in the last rc

@nodejs-github-bot nodejs-github-bot added the npm Issues and PRs related to the npm client dependency or the npm registry. label Oct 9, 2020
@MylesBorins
Copy link
Copy Markdown
Contributor Author

As this is an update to the existing npm rc could we please fast-track?

@MylesBorins MylesBorins added the fast-track PRs that do not need to wait for 72 hours to land. label Oct 9, 2020
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM

gengjiawen pushed a commit that referenced this pull request Oct 10, 2020
PR-URL: #35576
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@gengjiawen
Copy link
Copy Markdown
Member

Landed in dabc6dd

@gengjiawen gengjiawen closed this Oct 10, 2020
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
PR-URL: nodejs#35576
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track PRs that do not need to wait for 72 hours to land. npm Issues and PRs related to the npm client dependency or the npm registry.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants