Skip to content

doc: fix typos in quic.md#35444

Merged
lpinca merged 1 commit intonodejs:masterfrom
lpinca:fix/typos
Oct 4, 2020
Merged

doc: fix typos in quic.md#35444
lpinca merged 1 commit intonodejs:masterfrom
lpinca:fix/typos

Conversation

@lpinca
Copy link
Copy Markdown
Member

@lpinca lpinca commented Oct 1, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@lpinca lpinca requested a review from a team October 1, 2020 10:59
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/quic

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. dont-land-on-v12.x quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Oct 1, 2020
Copy link
Copy Markdown

@ItzLevvie ItzLevvie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jasnell
Copy link
Copy Markdown
Member

jasnell commented Oct 1, 2020

I see no reason for this to have to wait to land. Fast-track?

@jasnell jasnell added the fast-track PRs that do not need to wait for 72 hours to land. label Oct 1, 2020
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 1, 2020
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 1, 2020
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

PR-URL: nodejs#35444
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@lpinca lpinca merged commit e6d5af3 into nodejs:master Oct 4, 2020
@lpinca
Copy link
Copy Markdown
Member Author

lpinca commented Oct 4, 2020

Landed in e6d5af3.

@lpinca lpinca deleted the fix/typos branch October 4, 2020 05:59
@aduh95 aduh95 mentioned this pull request Nov 9, 2020
1 task
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
PR-URL: nodejs#35444
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 72 hours to land. quic Issues and PRs related to the QUIC implementation / HTTP/3.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants