Skip to content

Comments

deps: upgrade to c-ares v1.16.1#35324

Closed
codebytere wants to merge 1 commit intonodejs:masterfrom
codebytere:upgrade-to-cares-1.16.1
Closed

deps: upgrade to c-ares v1.16.1#35324
codebytere wants to merge 1 commit intonodejs:masterfrom
codebytere:upgrade-to-cares-1.16.1

Conversation

@codebytere
Copy link
Member

@codebytere codebytere commented Sep 24, 2020

Refs: https://github.com/c-ares/c-ares/releases/tag/cares-1_16_1

Includes c-ares/c-ares#328, which allows Electron to remove a patch.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@codebytere codebytere requested a review from a team as a code owner September 24, 2020 04:30
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 24, 2020 •
edited by codebytere
Loading

Review requested:

  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added the cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. label Sep 24, 2020
@codebytere codebytere added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 24, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 24, 2020
@gengjiawen gengjiawen mentioned this pull request Sep 24, 2020
Closed
@mmarchini
Copy link
Contributor

mmarchini commented Sep 24, 2020 •
edited
Loading

Jenkins is shutting down, probably why the CI didn't start (there are two jobs on the queue)

Edit: lol I thought I made that comment on #34594

@gengjiawen
Copy link
Member

gengjiawen commented Sep 24, 2020

Jenkins is shutting down, probably why the CI didn't start (there are two jobs on the queue)

Edit: lol I thought I made that comment on #34594

Looks like jenkins shutting down for a while. Does it run into any problem ? cc @nodejs/build

@rvagg
Copy link
Member

rvagg commented Sep 24, 2020

oh sorry!! I started an upgrade process but was dragged away from the computer for something urgent and picked up work on a different computer so I completely forgot I had this pending. Just finishing it up now, it'll be online shortly.

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 24, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 25, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/33246/

@Trott
Copy link
Member

Trott commented Sep 25, 2020 •
edited
Loading

Might be good to run an internet test in CI for this since there are a bunch of DNS tests there that are often overlooked (but we run them nightly in the node-daily-master job in CI).

Internet CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/16563/ ✅

@codebytere
Copy link
Member Author

codebytere commented Sep 26, 2020

Landed in aa99bb4

@codebytere codebytere closed this Sep 26, 2020
codebytere added a commit that referenced this pull request Sep 26, 2020
@codebytere
deps: upgrade to c-ares v1.16.1
aa99bb4 
PR-URL: #35324
Refs: https://github.com/c-ares/c-ares/releases/tag/cares-1_16_1
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@codebytere codebytere deleted the upgrade-to-cares-1.16.1 branch September 26, 2020 05:22
MylesBorins pushed a commit that referenced this pull request Sep 29, 2020
@codebytere @MylesBorins
deps: upgrade to c-ares v1.16.1
353a567 
PR-URL: #35324
Refs: https://github.com/c-ares/c-ares/releases/tag/cares-1_16_1
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Sep 29, 2020
Merged
codebytere added a commit to electron/electron that referenced this pull request Oct 6, 2020
@codebytere
Remove upstreamed c-ares patch
c41df05 
nodejs/node#35324
MylesBorins pushed a commit that referenced this pull request Nov 3, 2020
@codebytere @MylesBorins
deps: upgrade to c-ares v1.16.1
3a8fc81 
PR-URL: #35324
Refs: https://github.com/c-ares/c-ares/releases/tag/cares-1_16_1
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 3, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
@codebytere @MylesBorins
deps: upgrade to c-ares v1.16.1
cc11464 
PR-URL: #35324
Refs: https://github.com/c-ares/c-ares/releases/tag/cares-1_16_1
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@codebytere @joesepi
deps: upgrade to c-ares v1.16.1
a460ce9 
PR-URL: nodejs#35324
Refs: https://github.com/c-ares/c-ares/releases/tag/cares-1_16_1
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@richardlau richardlau richardlau approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@codebytere @nodejs-github-bot @mmarchini @gengjiawen @rvagg @Trott @bnoordhuis @addaleax @cjihrig @richardlau