quic: remove undefined variable#35007
Merged
Trott merged 1 commit intonodejs:masterfrom Sep 3, 2020
Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
dont-land-on-v12.x
quic
lpinca
approved these changes
Sep 1, 2020
jasnell
approved these changes
Sep 1, 2020
cjihrig
approved these changes
Sep 1, 2020
trivikr
approved these changes
Sep 1, 2020
github-actions
Bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
MrHeer
approved these changes
Sep 2, 2020
The `reason` variable never gets defined. It's use in a template string will always end up as the string `'undefined'`. PR-URL: nodejs#35007 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Member
Author
|
Landed in 449f73e |
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
The `reason` variable never gets defined. It's use in a template string will always end up as the string `'undefined'`. PR-URL: nodejs#35007 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
reasonvariable never gets defined. It's use in a template stringwill always end up as the string
'undefined'.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes