buffer: fix value check for writeUInt{B,L}E#3500
Closed
trevnorris wants to merge 1 commit intonodejs:masterfrom
Closed
buffer: fix value check for writeUInt{B,L}E#3500trevnorris wants to merge 1 commit intonodejs:masterfrom
trevnorris wants to merge 1 commit intonodejs:masterfrom
Conversation
Member
There was a problem hiding this comment.
I think Crankshaft and TurboFan are smart enough to move the Math.pow() call to the use site but the baseline compiler probably isn't, which would mean an extra Math.pow() call in the (unoptimized) common case.
Contributor
Author
There was a problem hiding this comment.
oh whoops. I just moved it b/c it didn't fit in 80 chars, but brain farted that i moved it outside the if. will fix.
Member
|
@trevnorris ... would you want this in v4.x? |
Contributor
Author
|
@jasnell bug fix, so I think so. |
trevnorris
force-pushed
the
buf-fix-uint-write
branch
from
3d2fd99 to
425d681
Compare
Contributor
Author
Contributor
Author
|
Two unrelated failures. Everything else looks good. |
trevnorris
force-pushed
the
buf-fix-uint-write
branch
2 times, most recently
from
540da8d to
67d4e96
Compare
Member
|
LGTM. Consider adding tests for byteLength > 1. |
Contributor
Author
Member
|
I only see tests for byteLength == 0 and 1 or am I missing something? |
trevnorris
force-pushed
the
buf-fix-uint-write
branch
from
67d4e96 to
559e66b
Compare
trevnorris
added a commit
that referenced
this pull request
Oct 26, 2015
Fixes: #3497 PR-URL: #3500 Reviewed-By: Ben Noordhuis <[email protected]>
Contributor
Author
|
Thanks for the review. Landed in 3308e5e. |
trevnorris
added a commit
that referenced
this pull request
Oct 26, 2015
Fixes: #3497 PR-URL: #3500 Reviewed-By: Ben Noordhuis <[email protected]>
trevnorris
added a commit
that referenced
this pull request
Oct 28, 2015
Fixes: #3497 PR-URL: #3500 Reviewed-By: Ben Noordhuis <[email protected]>
Member
|
Landed in v4.x-staging bc2120c |
trevnorris
added a commit
that referenced
this pull request
Oct 29, 2015
Fixes: #3497 PR-URL: #3500 Reviewed-By: Ben Noordhuis <[email protected]>
This was referenced Apr 29, 2023
This was referenced Jun 22, 2023
This was referenced Nov 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #3497
CI: https://ci.nodejs.org/job/node-test-pull-request/583/