Skip to content

Revert "deps: upgrade npm to 3.3.6"#3493

Closed
evanlucas wants to merge 1 commit intonodejs:masterfrom
evanlucas:revertnpm3
Closed

Revert "deps: upgrade npm to 3.3.6"#3493
evanlucas wants to merge 1 commit intonodejs:masterfrom
evanlucas:revertnpm3

Conversation

@evanlucas
Copy link
Copy Markdown
Contributor

@evanlucas evanlucas commented Oct 22, 2015

This reverts commit 41923c0.

We ran into the missing module issue again...

https://ci.nodejs.org/job/node-test-commit-osx/987/nodes=osx1010/console

/cc @Fishrock123

gyp ERR! UNCAUGHT EXCEPTION 
gyp ERR! stack Error: Cannot find module 'debug'
gyp ERR! stack     at Function.Module._resolveFilename (module.js:337:15)
gyp ERR! stack     at Function.Module._load (module.js:287:25)
gyp ERR! stack     at Module.require (module.js:366:17)
gyp ERR! stack     at require (module.js:385:17)
gyp ERR! stack     at Object.<anonymous> (/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1010/deps/npm/node_modules/array-index/index.js:7:13)
gyp ERR! stack     at Module._compile (module.js:425:26)
gyp ERR! stack     at Object.Module._extensions..js (module.js:432:10)
gyp ERR! stack     at Module.load (module.js:356:32)
gyp ERR! stack     at Function.Module._load (module.js:311:12)
gyp ERR! stack     at Module.require (module.js:366:17)
gyp ERR! stack     at require (module.js:385:17)
gyp ERR! System Darwin 14.5.0

Reference to original issue is at #1899

@evanlucas
Copy link
Copy Markdown
Contributor Author

evanlucas commented Oct 22, 2015

/cc @iarna

@jasnell
Copy link
Copy Markdown
Member

jasnell commented Oct 22, 2015

CI to see if that really does fix the problem on the CI side: https://ci.nodejs.org/job/node-test-pull-request/569/

@jbergstroem
Copy link
Copy Markdown
Member

jbergstroem commented Oct 22, 2015

This issue is making all bots go red.

@silverwind
Copy link
Copy Markdown
Contributor

silverwind commented Oct 22, 2015

A fix for this is scheduled in #2286: targos@59c8297.

@jasnell
Copy link
Copy Markdown
Member

jasnell commented Oct 22, 2015

@jbergstroem ... there's hope: https://ci.nodejs.org/job/node-test-commit-linux/1000/nodes=debian8-64/console ;-) Looks like reverting this commit saves the day on at least one of the bots so far

@iarna
Copy link
Copy Markdown
Member

iarna commented Oct 23, 2015

Looks like the .gitignore will need a small update. I'm PRing that now.

@jasnell
Copy link
Copy Markdown
Member

jasnell commented Oct 23, 2015

@iarna ... if we can get a quick patch in that fixes the issue, we can likely avoid the full revert. Given that this has happened before, tho, we likely need to tweak the test process a bit before npm updates land

@iarna iarna mentioned this pull request Oct 23, 2015
Closed
@iarna
Copy link
Copy Markdown
Member

iarna commented Oct 23, 2015

I can't actually make the previous change to the .gitignore work for me– I'll have to sit down with @zkat and figure out why it's behaving differently for the two of us.

In the meantime, there's #3494 to fix the specific problem here.

@mscdex mscdex added the npm Issues and PRs related to the npm client dependency or the npm registry. label Oct 23, 2015
@jasnell
Copy link
Copy Markdown
Member

jasnell commented Oct 23, 2015

Ok, 68471dd landed. Closing this.

@jasnell jasnell closed this Oct 23, 2015
This was referenced Apr 29, 2023
Open
Open
This was referenced Jun 22, 2023
Open
Open
Open
Open
Open
@leonardoadame leonardoadame mentioned this pull request Jul 9, 2023
Open
@aliscco aliscco mentioned this pull request Oct 27, 2023
Open
@aliscco aliscco mentioned this pull request Nov 28, 2023
Open
This was referenced Nov 29, 2023
Open
Open
@aliscco aliscco mentioned this pull request Dec 2, 2023
Open
@leonardoadame leonardoadame mentioned this pull request Dec 3, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

npm Issues and PRs related to the npm client dependency or the npm registry.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@evanlucas @jasnell @jbergstroem @silverwind @iarna @mscdex