doc: claim ABI version for Electron v12#34816
Closed
codebytere wants to merge 1 commit intonodejs:masterfrom
Closed
doc: claim ABI version for Electron v12#34816codebytere wants to merge 1 commit intonodejs:masterfrom
codebytere wants to merge 1 commit intonodejs:masterfrom
Conversation
Collaborator
|
Review requested:
|
codebytere
force-pushed
the
new-nmv-electron
branch
from
c5405d4 to
f205487
Compare
jasnell
approved these changes
Aug 17, 2020
mmarchini
approved these changes
Aug 17, 2020
richardlau
approved these changes
Aug 17, 2020
cjihrig
approved these changes
Aug 17, 2020
targos
approved these changes
Aug 18, 2020
lpinca
approved these changes
Aug 20, 2020
Member
Author
|
Landed in 7aeff6b |
codebytere
added a commit
that referenced
this pull request
Aug 20, 2020
PR-URL: #34816 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claiming Electron's ABI number for v12.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes