Skip to content

stream: refactor lazyLoadPromises#34354

Closed
rickyes wants to merge 1 commit intonodejs:masterfrom
rickyes:refactor-stream-lazyLoadPromises
Closed

stream: refactor lazyLoadPromises#34354
rickyes wants to merge 1 commit intonodejs:masterfrom
rickyes:refactor-stream-lazyLoadPromises

Conversation

@rickyes
Copy link
Copy Markdown
Contributor

@rickyes rickyes commented Jul 14, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the stream Issues and PRs related to the stream subsystem. label Jul 14, 2020
@rickyes
Copy link
Copy Markdown
Contributor Author

rickyes commented Jul 14, 2020

/cc @ronag @mcollina @addaleax

mcollina
mcollina approved these changes Jul 14, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 14, 2020
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Jul 14, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/32327/

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Jul 16, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/32372/

@mcollina
Copy link
Copy Markdown
Member

mcollina commented Jul 17, 2020

Landed in 5aeaff6

@mcollina mcollina closed this Jul 17, 2020
mcollina pushed a commit that referenced this pull request Jul 17, 2020
@rickyes @mcollina
stream: refactor lazyLoadPromises
5aeaff6 
PR-URL: #34354
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@rickyes rickyes deleted the refactor-stream-lazyLoadPromises branch July 17, 2020 15:15
@ruyadorno
Copy link
Copy Markdown
Member

ruyadorno commented Jul 22, 2020

Adding dont-land labels since this builds on top of a semver-major change

cjihrig pushed a commit that referenced this pull request Jul 23, 2020
@rickyes @cjihrig
stream: refactor lazyLoadPromises
840806e 
PR-URL: #34354
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@addaleax addaleax addaleax approved these changes

@ronag ronag ronag approved these changes

@himself65 himself65 himself65 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@rickyes @nodejs-github-bot @mcollina @ruyadorno @addaleax @ronag @himself65