Skip to content

build: add benchmark tests to CI runs#34288

Merged
Trott merged 0 commit intonodejs:masterfrom
Trott:benchmark-in-ci
Jul 14, 2020
Merged

build: add benchmark tests to CI runs#34288
Trott merged 0 commit intonodejs:masterfrom
Trott:benchmark-in-ci

Conversation

@Trott
Copy link
Member

@Trott Trott commented Jul 10, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. labels Jul 10, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
This was referenced Jul 12, 2020
Closed
Closed
@Trott Trott marked this pull request as ready for review July 12, 2020 16:34
@Trott Trott force-pushed the benchmark-in-ci branch from 56ea672 to a477913 Compare July 12, 2020 16:35
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@Trott
Copy link
Member Author

Trott commented Jul 12, 2020

@nodejs/testing

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 12, 2020 •
edited by Trott
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/32304/ ✔️

@Trott
Copy link
Member Author

Trott commented Jul 13, 2020

@nodejs/build @nodejs/collaborators This is ready to go, I think, but needs some approvals/reviews.

@Trott
Copy link
Member Author

Trott commented Jul 14, 2020

Landed in c7627da

@Trott Trott closed this Jul 14, 2020
@Trott Trott force-pushed the benchmark-in-ci branch from d0bd55f to c7627da Compare July 14, 2020 05:18
@Trott Trott merged commit c7627da into nodejs:master Jul 14, 2020
@Trott Trott deleted the benchmark-in-ci branch July 14, 2020 05:18
@MylesBorins
Copy link
Contributor

MylesBorins commented Jul 14, 2020

This is causing test failures when landed on v14.x. Would you be willing to open a backport?

Trott added a commit to Trott/io.js that referenced this pull request Jul 15, 2020
@Trott
build: add benchmark tests to CI runs
a6680e0 
Closes: nodejs#34321

PR-URL: nodejs#34288
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
@Trott
Copy link
Member Author

Trott commented Jul 15, 2020 •
edited
Loading

This is causing test failures when landed on v14.x. Would you be willing to open a backport?

Not sure where the CI results for this on 14.x are, so running this: https://ci.nodejs.org/job/node-test-commit/39653/

Mostly a note to self for later.

@Trott
Copy link
Member Author

Trott commented Jul 15, 2020

Not sure where the CI results for this on 14.x are, so running this: https://ci.nodejs.org/job/node-test-commit/39653/

No related test failures, I don't think. (One seemingly-unrelated macOS failure.) @MylesBorins Does this still need a backport or anything? Or can it go in as-is?

@richardlau richardlau mentioned this pull request Jul 17, 2020
Closed
cjihrig pushed a commit that referenced this pull request Jul 23, 2020
@Trott @cjihrig
build: add benchmark tests to CI runs
576f786 
Closes: #34321

PR-URL: #34288
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Jul 28, 2020
Merged
ruyadorno pushed a commit that referenced this pull request Jul 28, 2020
@Trott @ruyadorno
build: add benchmark tests to CI runs
8e3deca 
Closes: #34321

PR-URL: #34288
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
ruyadorno pushed a commit that referenced this pull request Jul 29, 2020
@Trott @ruyadorno
build: add benchmark tests to CI runs
b24f254 
Closes: #34321

PR-URL: #34288
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott @addaleax
build: add benchmark tests to CI runs
4d880a3 
Closes: #34321

PR-URL: #34288
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott @addaleax
build: add benchmark tests to CI runs
f14775e 
Closes: #34321

PR-URL: #34288
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
@mhdawson mhdawson mentioned this pull request Jan 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes

+1 more reviewer

@mmarchini mmarchini mmarchini approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Trott @nodejs-github-bot @MylesBorins @addaleax @mmarchini