Skip to content

tools: update ESLint to 7.4.0#34205

Merged
cjihrig merged 1 commit intonodejs:masterfrom
cjihrig:eslint
Jul 11, 2020
Merged

tools: update ESLint to 7.4.0#34205
cjihrig merged 1 commit intonodejs:masterfrom
cjihrig:eslint

Conversation

@cjihrig
Copy link
Copy Markdown
Contributor

@cjihrig cjihrig commented Jul 4, 2020

Update ESLint to 7.4.0

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jul 4, 2020
Copy link
Copy Markdown
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Jul 11, 2020

@cjihrig cjihrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 11, 2020
Update ESLint to 7.4.0

PR-URL: nodejs#34205
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@cjihrig cjihrig merged commit b0d4eb3 into nodejs:master Jul 11, 2020
@cjihrig cjihrig deleted the eslint branch July 11, 2020 19:52
@MylesBorins
Copy link
Copy Markdown
Contributor

this does not land cleanly on v14.x. Could someone backport or update on the v14.x branch

@Trott
Copy link
Copy Markdown
Member

Trott commented Jul 15, 2020

this does not land cleanly on v14.x. Could someone backport or update on the v14.x branch

@MylesBorins Cherry-pick 076e4ed first and then this PR/commit (b0d4eb3) will cherry-pick cleanly to v14.x-staging.

@targos targos added dont-land-on-v14.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-requested-v14.x labels Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants