Skip to content

doc: add missing backticks in timers.md#34030

Closed
vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom
vsemozhetbyt:doc-timers
Closed

doc: add missing backticks in timers.md#34030
vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom
vsemozhetbyt:doc-timers

Conversation

@vsemozhetbyt
Copy link
Copy Markdown
Contributor

@vsemozhetbyt vsemozhetbyt commented Jun 23, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. labels Jun 23, 2020
addaleax
addaleax approved these changes Jun 23, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 to fast-tracking

@addaleax addaleax added the fast-track PRs that do not need to wait for 72 hours to land. label Jun 23, 2020
@Trott
Copy link
Copy Markdown
Member

Trott commented Jun 24, 2020

Landed in 8ada275

@Trott Trott closed this Jun 24, 2020
Trott pushed a commit that referenced this pull request Jun 24, 2020
@vsemozhetbyt @Trott
doc: add missing backticks in timers.md
8ada275 
PR-URL: #34030
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@Trott
Copy link
Copy Markdown
Member

Trott commented Jun 24, 2020

Good to see you again, @vsemozhetbyt!

@vsemozhetbyt vsemozhetbyt deleted the doc-timers branch June 24, 2020 06:18
@MylesBorins
Copy link
Copy Markdown
Contributor

MylesBorins commented Jul 14, 2020

This change fixed an issue with a Semver-Major commit, as such I've labelled "don't land" for LTS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@richardlau richardlau richardlau approved these changes

+1 more reviewer

@rexagod rexagod rexagod approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 72 hours to land. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@vsemozhetbyt @Trott @MylesBorins @addaleax @lpinca @richardlau @rexagod @nodejs-github-bot