doc: document changes for */promises alias modules#34002
Closed
ExE-Boss wants to merge 1 commit intonodejs:masterfrom
Closed
doc: document changes for */promises alias modules#34002ExE-Boss wants to merge 1 commit intonodejs:masterfrom
*/promises alias modules#34002ExE-Boss wants to merge 1 commit intonodejs:masterfrom
Conversation
4 tasks
trivikr
approved these changes
Jun 22, 2020
trivikr
approved these changes
Jun 22, 2020
jasnell
approved these changes
Jun 22, 2020
shisama
approved these changes
Jun 22, 2020
Contributor
|
Is this semver-major as well as #32953? |
rexagod
approved these changes
Jun 22, 2020
Member
This appears to add metadata to the documentation. I don't think that can be semver-major, but maybe there's something I'm failing to consider. |
Member
|
It certainly shouldn’t land anywhere the actual change it’s documenting hasn’t landed. |
Member
|
ljharb
reviewed
Jun 24, 2020
jasnell
pushed a commit
that referenced
this pull request
Jun 25, 2020
Refs: #31553 Refs: #32953 PR-URL: #34001 Refs: #34002 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
4 tasks
ExE-Boss
added a commit
to ExE-Boss/node
that referenced
this pull request
Jun 27, 2020
Refs: nodejs#31553 Refs: nodejs#32953 Refs: nodejs#33950 Refs: nodejs#34001 Refs: nodejs#34002
4 tasks
ExE-Boss
added a commit
to ExE-Boss/node
that referenced
this pull request
Oct 6, 2020
Refs: nodejs#31553 Refs: nodejs#32953 Refs: nodejs#33950 Refs: nodejs#34001 Refs: nodejs#34002 Refs: nodejs#34055
ExE-Boss
requested review from
Trott and
ljharb
and removed request for
a team
Member
|
LGTM |
Trott
approved these changes
Oct 13, 2020
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 20, 2020
Refs: #31553 Refs: #32953 Refs: #33950 Refs: #34001 Refs: #34002 Refs: #34055 PR-URL: #34962 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Oct 20, 2020
Refs: #31553 Refs: #32953 Refs: #33950 Refs: #34001 Refs: #34002 PR-URL: #34055 Refs: #34962 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
ExE-Boss
force-pushed
the
doc/api/promises
branch
2 times, most recently
from
43387b5 to
e1f6257
Compare
Fixes: nodejs#35740 Refs: nodejs#31553 Refs: nodejs#32953 Refs: nodejs#33991 Refs: nodejs#34001 Refs: nodejs#34055 Refs: nodejs#34962 Co-authored-by: Antoine du Hamel <[email protected]> Co-authored-by: Trivikram Kamat <[email protected]> Co-authored-by: Rich Trott <[email protected]>
github-actions
Bot
removed
the
commit-queue
Contributor
Commit Queue failed- Loading data for nodejs/node/pull/34002 ✔ Done loading data for nodejs/node/pull/34002 ----------------------------------- PR info ------------------------------------ Title doc: document changes for `*/promises` alias modules (#34002) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch ExE-Boss:doc/api/promises -> nodejs:master Labels author ready, backport-requested-v12.x, backport-requested-v14.x, doc Commits 1 - doc: document changes for `*/promises` alias modules Committers 1 - ExE Boss <[email protected]> PR-URL: https://github.com/nodejs/node/pull/34002 Fixes: https://github.com/nodejs/node/issues/35740 Refs: https://github.com/nodejs/node/pull/31553 Refs: https://github.com/nodejs/node/pull/32953 Refs: https://github.com/nodejs/node/pull/33991 Refs: https://github.com/nodejs/node/pull/34001 Refs: https://github.com/nodejs/node/pull/34055 Refs: https://github.com/nodejs/node/pull/34962 Reviewed-By: Trivikram Kamat Reviewed-By: James M Snell Reviewed-By: Masashi Hirano Reviewed-By: Pranshu Srivastava Reviewed-By: Rich Trott Reviewed-By: Antoine du Hamel ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/34002 Fixes: https://github.com/nodejs/node/issues/35740 Refs: https://github.com/nodejs/node/pull/31553 Refs: https://github.com/nodejs/node/pull/32953 Refs: https://github.com/nodejs/node/pull/33991 Refs: https://github.com/nodejs/node/pull/34001 Refs: https://github.com/nodejs/node/pull/34055 Refs: https://github.com/nodejs/node/pull/34962 Reviewed-By: Trivikram Kamat Reviewed-By: James M Snell Reviewed-By: Masashi Hirano Reviewed-By: Pranshu Srivastava Reviewed-By: Rich Trott Reviewed-By: Antoine du Hamel -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - doc: document changes for `*/promises` alias modules ✖ GitHub CI is still running ℹ Doc-only changes ℹ This PR was created on Sun, 21 Jun 2020 13:24:57 GMT ✔ Approvals: 6 ✔ - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/34002#pullrequestreview-434903938 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/34002#pullrequestreview-434999352 ✔ - Masashi Hirano (@shisama): https://github.com/nodejs/node/pull/34002#pullrequestreview-435064239 ✔ - Pranshu Srivastava (@rexagod): https://github.com/nodejs/node/pull/34002#pullrequestreview-435078297 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/34002#pullrequestreview-514782300 ✔ - Antoine du Hamel (@aduh95): https://github.com/nodejs/node/pull/34002#pullrequestreview-516278221 -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu Commit Queue action: https://github.com/nodejs/node/actions/runs/325974420 |
github-actions
Bot
added
the
commit-queue-failed
Contributor
Author
aduh95
approved these changes
Oct 24, 2020
Trott
approved these changes
Oct 24, 2020
Contributor
Author
|
The GitHub CI tests have now finished, although test‑macOS/test‑macOS‑with‑quic has timed out. |
aduh95
added
commit-queue
github-actions
Bot
removed
the
commit-queue
Contributor
|
Landed in 3e10ce3...1d5b91d |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 25, 2020
Fixes: #35740 Refs: #31553 Refs: #32953 Refs: #33991 Refs: #34001 Refs: #34055 Refs: #34962 Co-authored-by: Antoine du Hamel <[email protected]> Co-authored-by: Trivikram Kamat <[email protected]> Co-authored-by: Rich Trott <[email protected]> PR-URL: #34002 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Masashi Hirano <[email protected]> Reviewed-By: Pranshu Srivastava <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 3, 2020
Fixes: #35740 Refs: #31553 Refs: #32953 Refs: #33991 Refs: #34001 Refs: #34055 Refs: #34962 Co-authored-by: Antoine du Hamel <[email protected]> Co-authored-by: Trivikram Kamat <[email protected]> Co-authored-by: Rich Trott <[email protected]> PR-URL: #34002 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Masashi Hirano <[email protected]> Reviewed-By: Pranshu Srivastava <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Nov 22, 2020
Refs: #31553 Refs: #32953 Refs: #33950 Refs: #34001 Refs: #34002 Refs: #34055 PR-URL: #34962 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Nov 22, 2020
Refs: #31553 Refs: #32953 Refs: #33950 Refs: #34001 Refs: #34002 PR-URL: #34055 Refs: #34962 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
targos
removed
backport-requested-v14.x
author ready
targos
pushed a commit
that referenced
this pull request
May 16, 2021
Fixes: #35740 Refs: #31553 Refs: #32953 Refs: #33991 Refs: #34001 Refs: #34055 Refs: #34962 Co-authored-by: Antoine du Hamel <[email protected]> Co-authored-by: Trivikram Kamat <[email protected]> Co-authored-by: Rich Trott <[email protected]> PR-URL: #34002 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Masashi Hirano <[email protected]> Reviewed-By: Pranshu Srivastava <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
Fixes: #35740 Refs: #31553 Refs: #32953 Refs: #33991 Refs: #34001 Refs: #34055 Refs: #34962 Co-authored-by: Antoine du Hamel <[email protected]> Co-authored-by: Trivikram Kamat <[email protected]> Co-authored-by: Rich Trott <[email protected]> PR-URL: #34002 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Masashi Hirano <[email protected]> Reviewed-By: Pranshu Srivastava <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #35740
Refs: #31553
Refs: #32953
Refs: #33991
Refs: #34001
Refs: #34055
Refs: #34962
Checklist