Skip to content

Conversation

@thecodrr
Copy link
Contributor

Hi, this is my first PR.

I was looking through the path.js source code and saw some grammar mistakes in one of the comments. Thought it would make a good first PR.

Checklist

@nodejs-github-bot nodejs-github-bot added the path Issues and PRs related to the path subsystem. label Apr 20, 2020
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 27, 2020
@nodejs-github-bot
Copy link
Collaborator

addaleax pushed a commit that referenced this pull request Apr 28, 2020
PR-URL: #32942
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
@addaleax
Copy link
Member

Landed in d0377a8 🎉

Thanks for being patient with us!

@addaleax addaleax closed this Apr 28, 2020
targos pushed a commit that referenced this pull request May 4, 2020
PR-URL: #32942
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
@targos targos mentioned this pull request May 4, 2020
targos pushed a commit that referenced this pull request May 7, 2020
PR-URL: #32942
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
targos pushed a commit that referenced this pull request May 13, 2020
PR-URL: #32942
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. path Issues and PRs related to the path subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants