Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Apr 12, 2020

Fixes: #25595

[x] make -j4 test (UNIX), or vcbuild test (Windows) passes
[x] documentation is changed or added
[x] commit message follows [commit guidelines]

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Apr 12, 2020
@Trott
Copy link
Member

Trott commented Apr 12, 2020

Welcome, @el5846, and thanks for the pull request! Just want to repeat what I said in the other pull request, which is that documentation pull requests can attract a lot of comments. Please be patient with us! Thanks!

@ghost ghost force-pushed the my-branch branch from ba4f37c to 977144b Compare April 12, 2020 04:57
@ghost ghost force-pushed the my-branch branch from 977144b to 0e490fb Compare April 14, 2020 22:29
Fixes: #25595

subdirectory

updated def
@ghost ghost force-pushed the my-branch branch from 0e490fb to c45d044 Compare April 14, 2020 22:32
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 17, 2020
@addaleax
Copy link
Member

@el5846 Sorry for the delay here!

Landed in ff622a2, and thanks for your pull request! 🎉

@addaleax addaleax closed this Apr 24, 2020
addaleax pushed a commit that referenced this pull request Apr 24, 2020
Fixes: #25595

subdirectory

updated def

PR-URL: #32791
Reviewed-By: Anna Henningsen <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 27, 2020
Fixes: #25595

subdirectory

updated def

PR-URL: #32791
Reviewed-By: Anna Henningsen <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Apr 27, 2020
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
Fixes: #25595

subdirectory

updated def

PR-URL: #32791
Reviewed-By: Anna Henningsen <[email protected]>
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
Fixes: #25595

subdirectory

updated def

PR-URL: #32791
Reviewed-By: Anna Henningsen <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Apr 28, 2020
BethGriggs pushed a commit that referenced this pull request Apr 28, 2020
Fixes: #25595

subdirectory

updated def

PR-URL: #32791
Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request Apr 30, 2020
Fixes: #25595

subdirectory

updated def

PR-URL: #32791
Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request May 13, 2020
Fixes: #25595

subdirectory

updated def

PR-URL: #32791
Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: Dirent definition doesn't tell me anything useful about Dirent

3 participants