src: consistently declare BindingData class#32677
Closed
sam-github wants to merge 1 commit intonodejs:masterfrom
Closed
src: consistently declare BindingData class#32677sam-github wants to merge 1 commit intonodejs:masterfrom
sam-github wants to merge 1 commit intonodejs:masterfrom
Conversation
Its defined as a class, so forward declare as a class, fixing type mismatch warning.
nodejs-github-bot
added
c++
addaleax
approved these changes
Apr 6, 2020
Member
|
👍 to fast-tracking from me |
2 tasks
Contributor
Author
|
Ok by me to fast-track, needs a couple more approvals before I can do that. |
richardlau
approved these changes
Apr 6, 2020
sam-github
added a commit
that referenced
this pull request
Apr 6, 2020
Its defined as a class, so forward declare as a class, fixing type mismatch warning. PR-URL: #32677 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Contributor
Author
|
Landed in 95c0885 |
BethGriggs
pushed a commit
that referenced
this pull request
Apr 7, 2020
Its defined as a class, so forward declare as a class, fixing type mismatch warning. PR-URL: #32677 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Its defined as a class, so forward declare as a class, fixing type
mismatch warning.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes