test: fix flaky test-fs-promises-file-handle-close#31687
Closed
addaleax wants to merge 2 commits intonodejs:masterfrom
Closed
test: fix flaky test-fs-promises-file-handle-close#31687addaleax wants to merge 2 commits intonodejs:masterfrom
addaleax wants to merge 2 commits intonodejs:masterfrom
Conversation
Sometimes, the expected warnings were not emitted. To harden the test: - Instead of relying on a timeout that raced against the file being opened, wait until the file is opened and then schedule GC after that. - Explicitly keep the event loop alive for one turn to make sure the warning is being seen.
addaleax
added
flaky-test
Trott
approved these changes
Feb 7, 2020
Collaborator
cjihrig
approved these changes
Feb 8, 2020
addaleax
added
the
author ready
BridgeAR
approved these changes
Feb 9, 2020
jasnell
approved these changes
Feb 10, 2020
Member
Author
|
Landed in 5100e84 |
addaleax
added a commit
that referenced
this pull request
Feb 10, 2020
Sometimes, the expected warnings were not emitted. To harden the test: - Instead of relying on a timeout that raced against the file being opened, wait until the file is opened and then schedule GC after that. - Explicitly keep the event loop alive for one turn to make sure the warning is being seen. PR-URL: #31687 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes, the expected warnings were not emitted.
To harden the test:
opened, wait until the file is opened and then schedule GC
after that.
the warning is being seen.
Example failure: https://ci.nodejs.org/job/node-test-commit-linux-containered/17920/nodes=ubuntu1804_sharedlibs_debug_x64/testReport/junit/(root)/test/parallel_test_fs_promises_file_handle_close/
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes