Skip to content

doc: simultaneous blog and email of sec announce #31483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sam-github wants to merge 1 commit into from
Closed

doc: simultaneous blog and email of sec announce #31483

sam-github wants to merge 1 commit into from

Conversation

@sam-github
Copy link
Contributor

@sam-github sam-github commented Jan 23, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 23, 2020
mhdawson
mhdawson approved these changes Jan 30, 2020
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sam-github
Copy link
Contributor Author

sam-github commented Jan 30, 2020

Landed in 38aa315

sam-github added a commit that referenced this pull request Jan 30, 2020
@sam-github
doc: simultaneous blog and email of sec announce
38aa315 
PR-URL: #31483
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@sam-github sam-github closed this Jan 30, 2020
@sam-github sam-github deleted the sec-announce-faster branch January 30, 2020 22:55
codebytere pushed a commit that referenced this pull request Feb 17, 2020
@sam-github @codebytere
doc: simultaneous blog and email of sec announce
4cac2cc 
PR-URL: #31483
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@codebytere codebytere mentioned this pull request Feb 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
@sam-github @codebytere
doc: simultaneous blog and email of sec announce
67cff50 
PR-URL: #31483
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@sam-github @codebytere
doc: simultaneous blog and email of sec announce
c8798a6 
PR-URL: #31483
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 30, 2020
@sam-github @codebytere
doc: simultaneous blog and email of sec announce
f4bdcf8 
PR-URL: #31483
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes

@mhdawson mhdawson mhdawson approved these changes

@MylesBorins MylesBorins Awaiting requested review from MylesBorins

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sam-github @Trott @mhdawson @nodejs-github-bot