stream: don't emit 'end' after 'error'#31182
Closed
ronag wants to merge 6 commits intonodejs:masterfrom
Closed
Conversation
nodejs-github-bot
added
the
stream
ronag
force-pushed
the
readable-end-error
branch
from
8996579 to
73c35c2
Compare
Member
Author
|
semver-major |
Trott
added
the
semver-major
Member
|
@nodejs/streams PTAL |
lpinca
reviewed
Jan 4, 2020
ronag
force-pushed
the
readable-end-error
branch
3 times, most recently
from
826b5d4 to
dfc361e
Compare
ronag
force-pushed
the
readable-end-error
branch
from
dfc361e to
9750a0b
Compare
lpinca
approved these changes
Jan 5, 2020
Trott
approved these changes
Jan 6, 2020
Trott
added
the
author ready
Member
|
CITGM looks good. |
Member
|
Landed in 66f4e4e |
Trott
pushed a commit
that referenced
this pull request
Jan 6, 2020
Refs: #6083 PR-URL: #31182 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rich Trott <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't emit 'end' after 'error'. There was still a case where this could occur (see test).
Note, that some tests that assume
'end'after'error'needed to be modified.Refs: #6083
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes