src: unset NODE_VERSION_IS_RELEASE from master#30584
Closed
targos wants to merge 1 commit intonodejs:masterfrom
Closed
src: unset NODE_VERSION_IS_RELEASE from master#30584targos wants to merge 1 commit intonodejs:masterfrom
targos wants to merge 1 commit intonodejs:masterfrom
Conversation
Member
Author
|
This fixes CI, let's fast-track! |
addaleax
approved these changes
Nov 22, 2019
gireeshpunathil
approved these changes
Nov 22, 2019
Member
@targos - curious what issues this was causing in the CI? I have been running and seeing a lot of failures in the CI for the C&L PRs, just want to know are those related some how. |
Member
Author
|
@gireeshpunathil When that bit is set, |
Contributor
|
apologies for missing this |
Contributor
|
There is a backlog on CI, this is definitely not going to break anything. I think we should land this immediately and skip waiting for CI. |
Member
|
+1 for landing without waiting for CI - saves a lot of runs. |
Contributor
|
Landed in 917fedd |
MylesBorins
pushed a commit
that referenced
this pull request
Nov 22, 2019
PR-URL: #30584 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Myles Borins <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.