doc: --enable-source-maps and prepareStackTrace are incompatible #30046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
document the fact that --enable-source-maps and prepareStackTrace are incompatible, see nodejs#29994
nodejs-github-bot
added
cli
devsnek
approved these changes
Oct 21, 2019
joyeecheung
reviewed
Oct 21, 2019
cjihrig
approved these changes
Oct 21, 2019
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
LGTM with the suggestions incorporated.
lpinca
approved these changes
Oct 21, 2019
joyeecheung
approved these changes
Oct 22, 2019
bcoe
pushed a commit
that referenced
this pull request
Oct 23, 2019
document the fact that --enable-source-maps and prepareStackTrace are incompatible, see #29994 PR-URL: #30046 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Contributor
Author
|
Landed in b964e77 |
MylesBorins
pushed a commit
that referenced
this pull request
Oct 23, 2019
document the fact that --enable-source-maps and prepareStackTrace are incompatible, see #29994 PR-URL: #30046 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 23, 2019
document the fact that --enable-source-maps and prepareStackTrace are incompatible, see #29994 PR-URL: #30046 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
Nov 8, 2019
document the fact that --enable-source-maps and prepareStackTrace are incompatible, see #29994 PR-URL: #30046 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 10, 2019
document the fact that --enable-source-maps and prepareStackTrace are incompatible, see #29994 PR-URL: #30046 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 11, 2019
document the fact that --enable-source-maps and prepareStackTrace are incompatible, see #29994 PR-URL: #30046 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
document the fact that
--enable-source-mapsandprepareStackTraceareincompatible, see #29994
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes