Skip to content

build: remove unnecessary Python semicolon #29170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Trott merged 0 commits into from
Aug 18, 2019
Merged

build: remove unnecessary Python semicolon #29170

Trott merged 0 commits into from
Aug 18, 2019

Conversation

@Trott
Copy link
Member

@Trott Trott commented Aug 16, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added i18n-api Issues and PRs related to the i18n implementation. tools Issues and PRs related to the tools directory. labels Aug 16, 2019
@Trott Trott mentioned this pull request Aug 16, 2019
Closed
1 task
MattIPv4
MattIPv4 approved these changes Aug 16, 2019
View reviewed changes
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@Trott Trott added the python PRs and issues that require attention from people who are familiar with Python. label Aug 16, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 16, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/25031/

@richardlau
Copy link
Member

richardlau commented Aug 16, 2019

(This file isn't run as part of the regular builds so a lite-CI would have been sufficient. It is used to generate deps/icu-small (e.g. on ICU updates see https://github.com/nodejs/node/blob/master/tools/icu/README.md).)

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 16, 2019
@Trott
Copy link
Member Author

Trott commented Aug 18, 2019

Landed in 27b7656

@Trott Trott closed this Aug 18, 2019
@Trott Trott merged commit 27b7656 into nodejs:master Aug 18, 2019
targos pushed a commit that referenced this pull request Aug 19, 2019
@MattIPv4 @targos
build: remove unnecessary Python semicolon
fbe25c7 
PR-URL: #29170
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@targos targos mentioned this pull request Aug 19, 2019
Merged
This was referenced Aug 20, 2019
Closed
Closed
Closed
Closed
Closed
Closed
@Trott Trott deleted the semipy branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss approved these changes

@richardlau richardlau richardlau approved these changes

@trivikr trivikr trivikr approved these changes

+1 more reviewer

@MattIPv4 MattIPv4 MattIPv4 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. i18n-api Issues and PRs related to the i18n implementation. python PRs and issues that require attention from people who are familiar with Python. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Trott @nodejs-github-bot @richardlau @cclauss @MattIPv4 @trivikr