Implement "exports" proposal#28568
Closed
hybrist wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the package.json "exports" proposal (https://github.com/jkrems/proposal-pkg-exports/) with the following features:
"exports"are defined for a package ({ "exports": { "./x": "./x.js" }), resolving that packageimport 'pkg/x', will resolve the exports path (/path/to/pkg/x.js)."exports", an error is thrown (see test case)."exports": falseto indicate a package has no exports at all.{ "./folder/": "./other-folder/" }).This reflects the consensus from this week's modules working group to move forward with
exportssupport in core.Items to be addressed before this feature is considered "fully done":
exportsin therequireloader.importsfield inpackage.json).The working group's recommendation was to address these items as follow-ups to keep the changes (and discussions) focussed on one thing at a time.
See: hybrist/proposal-pkg-exports#36
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes