doc: update readline asyncIterator docs #28425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
Trott
reviewed
Jun 25, 2019
Trott
reviewed
Jun 25, 2019
Trott
reviewed
Jun 25, 2019
Trott
approved these changes
Jun 25, 2019
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
I left some suggestions for more radical revisions of the text, but it's totally 👍 as-is.
lpinca
approved these changes
Jun 25, 2019
Contributor
Author
4 tasks
This commit: - Removes an unnecessary stability index entry. These generally are not included for Stable entries. - Remove mention of experimental status that is not true anymore. - Remove use of "we" - Remove use of relative time phrasing. - Misc cleanup. PR-URL: nodejs#28425 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Instead of `for`-`await`-`of`, prefer `for await...of`. PR-URL: nodejs#28425 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Contributor
Author
|
Landed in fd3a0d3...6045fbb, with a fresh green lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3725/ |
targos
pushed a commit
that referenced
this pull request
Jul 2, 2019
This commit: - Removes an unnecessary stability index entry. These generally are not included for Stable entries. - Remove mention of experimental status that is not true anymore. - Remove use of "we" - Remove use of relative time phrasing. - Misc cleanup. PR-URL: #28425 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 2, 2019
Instead of `for`-`await`-`of`, prefer `for await...of`. PR-URL: #28425 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 2, 2019
This commit: - Removes an unnecessary stability index entry. These generally are not included for Stable entries. - Remove mention of experimental status that is not true anymore. - Remove use of "we" - Remove use of relative time phrasing. - Misc cleanup. PR-URL: #28425 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 2, 2019
Instead of `for`-`await`-`of`, prefer `for await...of`. PR-URL: #28425 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This was referenced Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit:
for-await-of.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes