tools: fix js2c regression#27980
Closed
refack wants to merge 2 commits intonodejs:masterfrom
Closed
Conversation
refack
added
python
This comment has been minimized.
This comment has been minimized.
refack
commented
May 30, 2019
3 tasks
refack
force-pushed
the
fix-js2c-regression
branch
from
f473fa2 to
e302589
Compare
This comment has been minimized.
This comment has been minimized.
refack
force-pushed
the
fix-js2c-regression
branch
from
e302589 to
84aca5c
Compare
This comment has been minimized.
This comment has been minimized.
joyeecheung
reviewed
May 30, 2019
Member
There was a problem hiding this comment.
The builds are failing because this is private. I guess it would also make sense to add a public method to just return the source in a copy, though.
Contributor
Author
There was a problem hiding this comment.
I made it a friend
https://github.com/nodejs/node/blob/84aca5ca594f86ce9b6b86e6af039e78f90deaef/src/node_native_module.h#L89
and it compiles & passes with MSVC, now I need to figure out gcc & clang 🤷♂
Contributor
Author
There was a problem hiding this comment.
This comment has been minimized.
This comment has been minimized.
targos
approved these changes
May 31, 2019
bnoordhuis
approved these changes
Jun 1, 2019
Member
There was a problem hiding this comment.
Can you wrap this, e.g. by putting the for i in ... on its own line, lining it up with the e in [encoded_source?
refack
force-pushed
the
fix-js2c-regression
branch
from
8494bba to
6b0295c
Compare
joyeecheung
approved these changes
Jun 2, 2019
Member
|
Landed in cb92d24 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Jun 2, 2019
PR-URL: nodejs#27980 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jun 3, 2019
PR-URL: #27980 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a regression that was introduced in #25518 and causes the binary to bloat by ~10%.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes