child_process: setup stdio on error when possible#27696
Merged
cjihrig merged 1 commit intonodejs:masterfrom May 20, 2019
Merged
child_process: setup stdio on error when possible#27696cjihrig merged 1 commit intonodejs:masterfrom
cjihrig merged 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
child_process
Contributor
|
Is this |
Contributor
Author
|
It's a breaking change if code relies on stdio streams NOT being configured when spawn fails with |
Collaborator
|
EDIT(cjihrig): CI was yellow. |
Contributor
Author
|
Ping for reviews. |
Member
|
Optional suggestion: The current condition is covered in tests. Would be great if you could confirm that this is still covered with the change. |
Trott
approved these changes
May 17, 2019
Contributor
Author
|
@Trott both branches of the conditional are still covered. I also pushed up some assertions to verify it. We may miss coverage on the |
bnoordhuis
approved these changes
May 20, 2019
Member
There was a problem hiding this comment.
Oh hey, it's that comment's fifth birthday tomorrow - that's long enough for me to change my mind. :-)
Collaborator
|
EDIT(cjihrig): CI was yellow. |
As more spawn() errors are classified as runtime errors, it's no longer appropriate to only check UV_ENOENT when determining if stdio can be setup. This commit reverses the check to look for EMFILE and ENFILE specifically. PR-URL: nodejs#27696 Fixes: nodejs#26852 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
BridgeAR
pushed a commit
that referenced
this pull request
May 21, 2019
As more spawn() errors are classified as runtime errors, it's no longer appropriate to only check UV_ENOENT when determining if stdio can be setup. This commit reverses the check to look for EMFILE and ENFILE specifically. PR-URL: #27696 Fixes: #26852 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As more
spawn()errors are classified as runtime errors, it's no longer appropriate to only checkUV_ENOENTwhen determining if stdio can be setup. This commit reverses the check to look forEMFILEandENFILEspecifically.Fixes: #26852
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes