Skip to content

deps: V8: cherry-pick e0a109c#27533

Closed
joyeecheung wants to merge 2 commits intonodejs:masterfrom
joyeecheung:backport-rehash
Closed

deps: V8: cherry-pick e0a109c#27533
joyeecheung wants to merge 2 commits intonodejs:masterfrom
joyeecheung:backport-rehash

Conversation

@joyeecheung
Copy link
Copy Markdown
Member

@joyeecheung joyeecheung commented May 2, 2019

Original commit message:

[api] Implement StartupData::CanBeRehashed() for the snapshot blob

This enables the embedder to check if the snapshot generated
from SnapshotCreator::CreateBlob() can be rehashed and the seed
can be recomputed during deserialization.

The lack of this functionality resulted in a temporary vunerability
in Node.js: https://github.com/nodejs/node/pull/27365

Change-Id: I88d52337217c40f79c26438be3c87d2db874d980
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578661
Commit-Queue: Joyee Cheung <[email protected]>
Reviewed-by: Yang Guo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#61175}

Refs: v8/v8@e0a109c

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented May 2, 2019

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3425

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency. labels May 2, 2019
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented May 2, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/22889/

@joyeecheung
Copy link
Copy Markdown
Member Author

joyeecheung commented May 2, 2019

V8-CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/2266/

@joyeecheung joyeecheung requested a review from targos May 2, 2019 14:54
@joyeecheung
Copy link
Copy Markdown
Member Author

joyeecheung commented May 2, 2019

hmm, somehow on our branch the snapshots generated in the tests are not rehashable https://ci.nodejs.org/job/node-test-commit-v8-linux/2266/

There may be some other commits that we need to backport together? @hashseed

@joyeecheung
Copy link
Copy Markdown
Member Author

joyeecheung commented May 2, 2019 •
edited
Loading

Ah, the failures are all Check failed: !blob.CanBeRehashed(), which means the ExtractRehashability() on our branch may be bogus..(because having maps in the snapshot here does fail the pummel/test-hash-seed test)

@joyeecheung
deps: V8: cherry-pick e0a109c
2702abb 
Original commit message:

    [api] Implement StartupData::CanBeRehashed() for the snapshot blob

    This enables the embedder to check if the snapshot generated
    from SnapshotCreator::CreateBlob() can be rehashed and the seed
    can be recomputed during deserialization.

    The lack of this functionality resulted in a temporary vunerability
    in Node.js: nodejs#27365

    Change-Id: I88d52337217c40f79c26438be3c87d2db874d980
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578661
    Commit-Queue: Joyee Cheung <[email protected]>
    Reviewed-by: Yang Guo <[email protected]>
    Cr-Commit-Position: refs/heads/master@{nodejs#61175}

Refs: v8/v8@e0a109c
@joyeecheung
fixup! deps: V8: cherry-pick e0a109c
0b06ddf
@joyeecheung
Copy link
Copy Markdown
Member Author

joyeecheung commented Jun 6, 2019

OK, looks like somehow the patch was applied incorrectly and the assertions went to the wrong places. I've moved them to be in the correct location.

@targos maybe you want to take another look? (though it's just correcting the patch to be the same as the one in the upstream)

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Jun 6, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/23658/

@joyeecheung
Copy link
Copy Markdown
Member Author

joyeecheung commented Jun 6, 2019

V8-CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/2361/

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Jun 9, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/23723/

@joyeecheung
Copy link
Copy Markdown
Member Author

joyeecheung commented Jun 9, 2019

V8-CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/2366

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 9, 2019
@joyeecheung
Copy link
Copy Markdown
Member Author

joyeecheung commented Jun 11, 2019

Landed in d2634be

joyeecheung added a commit that referenced this pull request Jun 11, 2019
@joyeecheung
deps: V8: cherry-pick e0a109c
d2634be 
Original commit message:

    [api] Implement StartupData::CanBeRehashed() for the snapshot blob

    This enables the embedder to check if the snapshot generated
    from SnapshotCreator::CreateBlob() can be rehashed and the seed
    can be recomputed during deserialization.

    The lack of this functionality resulted in a temporary vunerability
    in Node.js: #27365

    Change-Id: I88d52337217c40f79c26438be3c87d2db874d980
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578661
    Commit-Queue: Joyee Cheung <[email protected]>
    Reviewed-by: Yang Guo <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#61175}

Refs: v8/v8@e0a109c

PR-URL: #27533
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
BridgeAR pushed a commit that referenced this pull request Jun 17, 2019
@joyeecheung @BridgeAR
deps: V8: cherry-pick e0a109c
9382b3b 
Original commit message:

    [api] Implement StartupData::CanBeRehashed() for the snapshot blob

    This enables the embedder to check if the snapshot generated
    from SnapshotCreator::CreateBlob() can be rehashed and the seed
    can be recomputed during deserialization.

    The lack of this functionality resulted in a temporary vunerability
    in Node.js: #27365

    Change-Id: I88d52337217c40f79c26438be3c87d2db874d980
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578661
    Commit-Queue: Joyee Cheung <[email protected]>
    Reviewed-by: Yang Guo <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#61175}

Refs: v8/v8@e0a109c

PR-URL: #27533
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Jun 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes

@targos targos targos approved these changes

+1 more reviewer

@refack refack refack approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@joyeecheung @nodejs-github-bot @refack @Trott @targos