Skip to content

src: apply clang-tidy readability-delete-null-pointer #26813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
refack merged 1 commit into from
Mar 22, 2019
Merged

src: apply clang-tidy readability-delete-null-pointer #26813

refack merged 1 commit into from
Mar 22, 2019

Conversation

@gengjiawen
Copy link
Member

@gengjiawen gengjiawen commented Mar 20, 2019 •
edited by refack
Loading

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Mar 20, 2019
@refack
Copy link
Contributor

refack commented Mar 20, 2019 •
edited
Loading

@gengjiawen I think you should add a .clang-tidy file to the /src/ directory (like V8's) and add each rule you fix...

CI: https://ci.nodejs.org/job/node-test-pull-request/21696/
Resume: https://ci.nodejs.org/job/node-test-pull-request/21704/

@gengjiawen
Copy link
Member Author

gengjiawen commented Mar 20, 2019

yeap, but I am still working on a way to ensure the rules.

@refack
Copy link
Contributor

refack commented Mar 20, 2019

Very preliminary https://ci.nodejs.org/job/node-clang-tidy/1/console

@refack refack added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 20, 2019
@gengjiawen gengjiawen mentioned this pull request Mar 21, 2019
Closed
2 tasks
@joyeecheung joyeecheung mentioned this pull request Mar 22, 2019
Closed
@gengjiawen @refack
src: apply clang-tidy readability-delete-null-pointer
c757cb1 
PR-URL: nodejs#26813
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@refack refack force-pushed the readability-delete-null-pointer branch from 6838311 to c757cb1 Compare March 22, 2019 22:36
@refack refack merged commit c757cb1 into nodejs:master Mar 22, 2019
targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019
@gengjiawen @targos
src: apply clang-tidy readability-delete-null-pointer
e81b01e 
PR-URL: nodejs#26813
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request Mar 27, 2019
@gengjiawen @targos
src: apply clang-tidy readability-delete-null-pointer
6de2437 
PR-URL: #26813
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@targos targos mentioned this pull request Mar 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@addaleax addaleax addaleax approved these changes

@richardlau richardlau richardlau approved these changes

+1 more reviewer

@refack refack refack approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gengjiawen @refack @bnoordhuis @addaleax @richardlau @nodejs-github-bot