lib: lazy load v8 in error-serdes#26689
Closed
richardlau wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
This comment has been minimized.
This comment has been minimized.
Lazy loading `v8` in `lib/internal/error-serdes.js` reduces the number of loaded modules by the bootstrap code for Worker threads by seven. Refs: nodejs#26501 (comment)
Member
|
The code LGTM, but it might be worth pointing out that once we have snapshot support, we want as many modules loaded during bootstrap as possible, as opposed to as few as possible. |
Member
Author
I have no objections to closing this if it's not worth it. |
BridgeAR
approved these changes
Mar 15, 2019
Member
|
@addaleax I would like to experiment with the snapshots as soon as we fully implement them in a way to see what's best. If I am not mistaken we could still have a code cache for the lazy loaded modules which could be a good middle ground for all users. |
BridgeAR
added
the
author ready
jasnell
approved these changes
Mar 16, 2019
Member
Author
cjihrig
approved these changes
Mar 16, 2019
Contributor
|
Landed in 927f29d. |
pull Bot
pushed a commit
to SimenB/node
that referenced
this pull request
Mar 19, 2019
Lazy loading `v8` in `lib/internal/error-serdes.js` reduces the number of loaded modules by the bootstrap code for Worker threads by seven. PR-URL: nodejs#26689 Refs: nodejs#26501 (comment) Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos
pushed a commit
that referenced
this pull request
Mar 27, 2019
Lazy loading `v8` in `lib/internal/error-serdes.js` reduces the number of loaded modules by the bootstrap code for Worker threads by seven. PR-URL: #26689 Refs: #26501 (comment) Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lazy loading
v8inlib/internal/error-serdes.jsreduces the numberof loaded modules by the bootstrap code for Worker threads by seven.
Refs: #26501 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes