process: use common operations to define browser globals#26230
Closed
joyeecheung wants to merge 1 commit intonodejs:masterfrom
Closed
process: use common operations to define browser globals#26230joyeecheung wants to merge 1 commit intonodejs:masterfrom
joyeecheung wants to merge 1 commit intonodejs:masterfrom
Conversation
jasnell
approved these changes
Feb 21, 2019
joyeecheung
force-pushed
the
share-op
branch
from
1cbe720 to
77ad589
Compare
Extracts: - `exposeNamespace`: https://heycam.github.io/webidl/#es-namespaces - `exposeInterface`: https://heycam.github.io/webidl/#es-interfaces - `defineOperation`: https://heycam.github.io/webidl/#define-the-operations into functions to define browser globals.
joyeecheung
force-pushed
the
share-op
branch
from
77ad589 to
aa38670
Compare
devsnek
approved these changes
Feb 21, 2019
BridgeAR
approved these changes
Feb 21, 2019
BridgeAR
added
process
cjihrig
approved these changes
Feb 21, 2019
pull Bot
pushed a commit
to shakir-abdo/node
that referenced
this pull request
Feb 25, 2019
Extracts: - `exposeNamespace`: https://heycam.github.io/webidl/#es-namespaces - `exposeInterface`: https://heycam.github.io/webidl/#es-interfaces - `defineOperation`: https://heycam.github.io/webidl/#define-the-operations into functions to define browser globals. PR-URL: nodejs#26230 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Feb 25, 2019
Extracts: - `exposeNamespace`: https://heycam.github.io/webidl/#es-namespaces - `exposeInterface`: https://heycam.github.io/webidl/#es-interfaces - `defineOperation`: https://heycam.github.io/webidl/#define-the-operations into functions to define browser globals. PR-URL: #26230 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Member
Author
|
Landed in bba27a1 |
Merged
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
Extracts: - `exposeNamespace`: https://heycam.github.io/webidl/#es-namespaces - `exposeInterface`: https://heycam.github.io/webidl/#es-interfaces - `defineOperation`: https://heycam.github.io/webidl/#define-the-operations into functions to define browser globals. PR-URL: #26230 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts:
exposeNamespace: https://heycam.github.io/webidl/#es-namespacesexposeInterface: https://heycam.github.io/webidl/#es-interfacesdefineOperation: https://heycam.github.io/webidl/#define-the-operationsinto functions to define browser globals.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes