Skip to content

http2: compat support for nested array headers #24665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sebdeckers wants to merge 1 commit into from
Closed

http2: compat support for nested array headers #24665

sebdeckers wants to merge 1 commit into from

Conversation

@sebdeckers
Copy link
Contributor

@sebdeckers sebdeckers commented Nov 27, 2018

writeHead supports an array of arrays containing header name and values.

Compatibility between http2 & http1 even though this is not documented.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@sebdeckers
http2: compat support for nested array headers
c92863f 
writeHead supports an array of arrays containing header name and values.
Compatibility between http2 & http1 even though this is not documented.

Fixes: nodejs#24466
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 27, 2018

@sebdeckers sadly an error occured when I tried to trigger a build :(

@nodejs-github-bot nodejs-github-bot added dont-land-on-v6.x http2 Issues or PRs related to the http2 subsystem. labels Nov 27, 2018
@sebdeckers sebdeckers requested a review from jasnell November 27, 2018 02:52
leeight
leeight reviewed Nov 27, 2018
View reviewed changes
leeight
leeight reviewed Nov 27, 2018
View reviewed changes
@Trott
Copy link
Member

Trott commented Nov 29, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/19031/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 29, 2018
@sebdeckers
Copy link
Contributor Author

sebdeckers commented Nov 29, 2018

@Trott What does that CI failure mean? I don't see how it relates to the patch.

AssertionError [ERR_ASSERTION]: bootstrapComplete: 1136.0168499946594 >= 1111
    at checkNodeTiming (/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos17-64/test/sequential/test-performance.js:92:7)

@jasnell
Copy link
Member

jasnell commented Nov 29, 2018

That's likely an unrelated flaky failure but we can run again to verify

@Trott
Copy link
Member

Trott commented Nov 29, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19053/

@Trott
Copy link
Member

Trott commented Nov 29, 2018

Once more but with feeling: https://ci.nodejs.org/job/node-test-pull-request/19061/

@Trott
Copy link
Member

Trott commented Nov 29, 2018

Landed in 5dacbf5

@Trott Trott closed this Nov 29, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 29, 2018
@sebdeckers @Trott
http2: add compat support for nested array headers
5dacbf5 
writeHead supports an array of arrays containing header name and values.
Compatibility between http2 & http1 even though this is not documented.

Fixes: nodejs#24466

PR-URL: nodejs#24665
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Nov 29, 2018
@sebdeckers @targos
http2: add compat support for nested array headers
61e0103 
writeHead supports an array of arrays containing header name and values.
Compatibility between http2 & http1 even though this is not documented.

Fixes: #24466

PR-URL: #24665
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@sebdeckers
Copy link
Contributor Author

sebdeckers commented Nov 29, 2018

Thanks for the help, @Trott and everyone who reviewed/commented. 🙇🏻‍♂️

@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@sebdeckers @refack
http2: add compat support for nested array headers
a5705ce 
writeHead supports an array of arrays containing header name and values.
Compatibility between http2 & http1 even though this is not documented.

Fixes: nodejs#24466

PR-URL: nodejs#24665
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@sebdeckers @BethGriggs
http2: add compat support for nested array headers
d12c5a7 
writeHead supports an array of arrays containing header name and values.
Compatibility between http2 & http1 even though this is not documented.

Fixes: #24466

PR-URL: #24665
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@sebdeckers @rvagg
http2: add compat support for nested array headers
8e8035e 
writeHead supports an array of arrays containing header name and values.
Compatibility between http2 & http1 even though this is not documented.

Fixes: #24466

PR-URL: #24665
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott left review comments

@fhinkel fhinkel fhinkel approved these changes

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

+1 more reviewer

@leeight leeight leeight left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. http2 Issues or PRs related to the http2 subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@sebdeckers @nodejs-github-bot @Trott @jasnell @fhinkel @leeight @addaleax @lpinca @cjihrig