test: assertion equality fix#24422
Closed
NoSkillGirl wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
In test-net-write-callback.js, when process exits, we check of callback count with the expected value. written assert.strictEqual(N, cbcount), which expects N to equal to cbcount, instead we should expect cbcount to be equal to cbcount.
gireeshpunathil
added
the
code-and-learn
targos
approved these changes
Nov 17, 2018
Member
targos
left a comment
targos
left a comment
There was a problem hiding this comment.
Changes LGTM.
Commit message should look like test: fix ...
Member
|
👍 to fast-track |
gireeshpunathil
approved these changes
Nov 18, 2018
trivikr
approved these changes
Nov 18, 2018
oyyd
approved these changes
Nov 18, 2018
cjihrig
approved these changes
Nov 18, 2018
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Nov 19, 2018
In test-net-write-callback.js, when process exits, we check callback count against the expected value. The assertion is written with the expected value first and actual value second, but that is the opposite of the documented argument order. Reverse them to be consistent with documentation. PR-URL: nodejs#24422 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ouyang Yadong <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Member
|
Landed in dafd76c. (I edited the commit message.) Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
targos
pushed a commit
that referenced
this pull request
Nov 19, 2018
In test-net-write-callback.js, when process exits, we check callback count against the expected value. The assertion is written with the expected value first and actual value second, but that is the opposite of the documented argument order. Reverse them to be consistent with documentation. PR-URL: #24422 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ouyang Yadong <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Contributor
Author
|
Hi @gireeshpunathil, Is this pull request merged or closed ? @Trott edited the commit message and the PR got reviewed by multiple people. @Trott kept a "Thanks for the contribution!" message But i see the PR got closed with unmerged commits. |
Member
|
@NoSkillGirl The "closed" is an artifact of the way I merged the commit, but it's really there in master. See dafd76c. |
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
In test-net-write-callback.js, when process exits, we check callback count against the expected value. The assertion is written with the expected value first and actual value second, but that is the opposite of the documented argument order. Reverse them to be consistent with documentation. PR-URL: #24422 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ouyang Yadong <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
This was referenced Dec 7, 2018
codebytere
pushed a commit
that referenced
this pull request
Jan 13, 2019
In test-net-write-callback.js, when process exits, we check callback count against the expected value. The assertion is written with the expected value first and actual value second, but that is the opposite of the documented argument order. Reverse them to be consistent with documentation. PR-URL: #24422 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ouyang Yadong <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
In test-net-write-callback.js, when process exits, we check callback count against the expected value. The assertion is written with the expected value first and actual value second, but that is the opposite of the documented argument order. Reverse them to be consistent with documentation. PR-URL: nodejs#24422 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ouyang Yadong <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jan 29, 2019
In test-net-write-callback.js, when process exits, we check callback count against the expected value. The assertion is written with the expected value first and actual value second, but that is the opposite of the documented argument order. Reverse them to be consistent with documentation. PR-URL: #24422 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ouyang Yadong <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
This was referenced Jan 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In test-net-write-callback.js, when the process exits, we check of callback
count with the expected value. written assert.strictEqual(N, cbcount),
which expects N to equal to cbcount, instead we should expect cbcount to be equal to cbcount.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes