Skip to content

[addons] Implement new init function argument dispatch #2329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
agnat wants to merge 5 commits into from
Closed

[addons] Implement new init function argument dispatch #2329

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
986acf6
[addons] Implement new init function argument dispatch
agnat Aug 8, 2015
b27c7f2
[addons] Use new init dispatch in builtin modules
agnat Aug 8, 2015
ea26808
[addons] Address style issues
agnat Aug 8, 2015
850fb5f
[addons] Styled a few more pointers
agnat Aug 8, 2015
1e99809
[addons] Fix inizialization order issue
agnat Aug 15, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[addons] Fix inizialization order issue 
Use construct on first use to avoid static inizialization order issues.
  • Loading branch information
@agnat
agnat committed Aug 15, 2015
commit 1e9980977e09376d2d7e8b6b852a4d9da4b7e330
26 changes: 13 additions & 13 deletions src/node.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,20 +504,20 @@ extern "C" NODE_EXTERN void node_module_register(void* mod);

#define NODE_MODULE_X(modname, initfunc, priv, flags) \
extern "C" { \
static node::node_module _module_ ## modname = \
{ \
NODE_MODULE_VERSION, \
flags, \
NULL, \
__FILE__, \
node::detail::selectAddonRegisterFunction(initfunc), \
reinterpret_cast<void*>(initfunc), \
NODE_STRINGIFY(modname), \
priv, \
NULL \
}; \
NODE_C_CTOR(_register_ ## modname) { \
node_module_register(&_module_ ## modname); \
static node::node_module _module = \
{ \
NODE_MODULE_VERSION, \
flags, \
NULL, \
__FILE__, \
node::detail::selectAddonRegisterFunction(initfunc), \
reinterpret_cast<void*>(initfunc), \
NODE_STRINGIFY(modname), \
priv, \
NULL \
}; \
node_module_register(&_module); \
} \
}

Expand Down