Skip to content

test-child-process-disconnected.js added more descriptive error message to test's assert#23118

Closed
Josh-Broomfield wants to merge 3 commits intonodejs:masterfrom
Josh-Broomfield:test-child-process-disconnect_assert-error
Closed

test-child-process-disconnected.js added more descriptive error message to test's assert#23118
Josh-Broomfield wants to merge 3 commits intonodejs:masterfrom
Josh-Broomfield:test-child-process-disconnect_assert-error

Conversation

@Josh-Broomfield
Copy link
Copy Markdown
Contributor

@Josh-Broomfield Josh-Broomfield commented Sep 27, 2018

No description provided.

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Sep 27, 2018
@gireeshpunathil
Copy link
Copy Markdown
Member

gireeshpunathil commented Sep 27, 2018

hello @Josh-Broomfield - thanks for the PR. there is linter error reported:

test/parallel/test-child-process-disconnect.js
  97:42  error  Trailing spaces not allowed  no-trailing-spaces

can you fix that and push again? thanks. ( run make -j4 test that will catch all these types of issues)

@Trott
Copy link
Copy Markdown
Member

Trott commented Sep 27, 2018

can you fix that and push again? thanks. ( run make -j4 test that will catch all these types of issues)

And if you just want to quickly lint JS files only without running all the tests, you can use make lint-js.

@Trott
Copy link
Copy Markdown
Member

Trott commented Sep 27, 2018

Change looks good to me once lint issue is addressed.

@Trott
Copy link
Copy Markdown
Member

Trott commented Sep 27, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/17476/

@Trott
Copy link
Copy Markdown
Member

Trott commented Sep 28, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/17499/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 30, 2018
@addaleax
Copy link
Copy Markdown
Member

addaleax commented Sep 30, 2018

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/17529/

@joyeecheung joyeecheung mentioned this pull request Oct 2, 2018
Closed
@danbev
Copy link
Copy Markdown
Contributor

danbev commented Oct 3, 2018 •
edited
Loading

Re-run of failing node-test-commit-linux ✔️
Re-run of failing node-test-commit-arm ✔️
Re-run of failing node-test-commit-linux-containered ✔️

@danbev
Copy link
Copy Markdown
Contributor

danbev commented Oct 3, 2018

Landed in 2f36cb4.

@danbev danbev closed this Oct 3, 2018
danbev pushed a commit that referenced this pull request Oct 3, 2018
@Josh-Broomfield @danbev
test: add more descriptive err message to assert
2f36cb4 
PR-URL: #23118
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@Trott
Copy link
Copy Markdown
Member

Trott commented Oct 3, 2018

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

targos pushed a commit that referenced this pull request Oct 4, 2018
@Josh-Broomfield @targos
test: add more descriptive err message to assert
44db98a 
PR-URL: #23118
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos mentioned this pull request Oct 7, 2018
Merged
This was referenced Oct 10, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Oct 11, 2018
Closed
Closed
Closed
@Josh-Broomfield
Copy link
Copy Markdown
Contributor Author

Josh-Broomfield commented Oct 11, 2018

Could this be reopened please? I'd like to try a bunch of different things since I'm unfamiliar with open source.

@addaleax
Copy link
Copy Markdown
Member

addaleax commented Oct 11, 2018

@Josh-Broomfield This pull request has been merged into our master branch – if you’d like to propose new changes, I think it would be best to do so with new pull request?

@Josh-Broomfield
Copy link
Copy Markdown
Contributor Author

Josh-Broomfield commented Oct 11, 2018 •
edited
Loading

Oh sorry I figured since it failed some tests that it wasn't. I'll be looking into the next steps link then. Thanks.

jasnell pushed a commit that referenced this pull request Oct 17, 2018
@Josh-Broomfield @jasnell
test: add more descriptive err message to assert
e03dce2 
PR-URL: #23118
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

+1 more reviewer

@thefourtheye thefourtheye thefourtheye approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@Josh-Broomfield @gireeshpunathil @Trott @addaleax @danbev @jasnell @thefourtheye @nodejs-github-bot