Skip to content

vm: move process.binding('contextify') to internalBinding#22419

Closed
jasnell wants to merge 1 commit intonodejs:masterfrom
jasnell:contextify-internal-binding
Closed

vm: move process.binding('contextify') to internalBinding#22419
jasnell wants to merge 1 commit intonodejs:masterfrom
jasnell:contextify-internal-binding

Conversation

@jasnell
Copy link
Copy Markdown
Member

@jasnell jasnell commented Aug 20, 2018

Refs: #22160

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@jasnell jasnell added vm Issues and PRs related to the vm subsystem. semver-major PRs that contain breaking changes and should be released in the next major version. labels Aug 20, 2018
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Aug 20, 2018

@jasnell build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/605/pipeline

@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Aug 20, 2018
@jasnell jasnell mentioned this pull request Aug 20, 2018
Closed
33 tasks
@jasnell
Copy link
Copy Markdown
Member Author

jasnell commented Aug 21, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/16631/

@jasnell jasnell requested a review from a team August 21, 2018 13:36
@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 21, 2018
@jasnell
Copy link
Copy Markdown
Member Author

jasnell commented Aug 21, 2018

Unrelated CI failures, resuming: https://ci.nodejs.org/job/node-test-pull-request/16636/

@jasnell
Copy link
Copy Markdown
Member Author

jasnell commented Aug 21, 2018

@nodejs/build ... complete CI failure on the arm cluster: https://ci.nodejs.org/job/node-test-binary-arm/2979/

@jasnell
Copy link
Copy Markdown
Member Author

jasnell commented Aug 21, 2018

Resuming again because of more unrelated CI failures: https://ci.nodejs.org/job/node-test-pull-request/16644/

@refack
Copy link
Copy Markdown
Contributor

refack commented Aug 22, 2018

@nodejs/build ... complete CI failure on the arm cluster: ci.nodejs.org/job/node-test-binary-arm/2979

arm cluster failure was due to a power outage at the "requireIO" HQ. it has been dealt with.

@jasnell
Copy link
Copy Markdown
Member Author

jasnell commented Aug 22, 2018

Resuming CI again: https://ci.nodejs.org/job/node-test-pull-request/16658/

@refack
Copy link
Copy Markdown
Contributor

refack commented Aug 22, 2018

REsume CI: https://ci.nodejs.org/job/node-test-pull-request/16659/

@jasnell
Copy link
Copy Markdown
Member Author

jasnell commented Aug 22, 2018

CI is finally good! Need one more @nodejs/tsc sign off before I can land tho

@jasnell jasnell requested a review from a team August 22, 2018 03:51
@jasnell jasnell force-pushed the contextify-internal-binding branch from 2677164 to ee130c1 Compare August 23, 2018 22:56
jasnell added a commit that referenced this pull request Aug 23, 2018
@jasnell
vm: move process.binding('contextify') to internalBinding
4963a04 
PR-URL: #22419
Refs: #22160
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@jasnell
Copy link
Copy Markdown
Member Author

jasnell commented Aug 23, 2018

Landed in 4963a04

@jasnell jasnell closed this Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

+1 more reviewer

@refack refack refack approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory. semver-major PRs that contain breaking changes and should be released in the next major version. vm Issues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jasnell @nodejs-github-bot @refack @addaleax @cjihrig @BridgeAR @trivikr