benchmark: remove es benchmark#22361
Closed
psmarshall wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
nodejs-github-bot
added
benchmark
BridgeAR
approved these changes
Aug 16, 2018
apapirovski
approved these changes
Aug 16, 2018
cjihrig
approved these changes
Aug 16, 2018
Member
|
I'm generally -1 on this but won't block. I use these frequently to test improvements in performance across v8 updates. |
Contributor
|
I agree with @jasnell that these benchmarks can still be useful to us. |
Member
BridgeAR
added
the
author ready
trivikr
approved these changes
Aug 17, 2018
Member
|
This PR needs a rebase against master to avoid the git failure in the CI. |
Contributor
Author
|
@jasnell If you are using this frequently then I guess it is worth keeping - I'd argue these types of benchmarks are better suited to external suites like six-speed but I guess in your case, the benefit is having the performance runner within node and getting the numbers out in a format that is useful to you. |
Contributor
Author
|
I'm going to close this given that it is in use. We could revisit it once:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesThese benchmarks compare the performance of ES6 features and their ES5 equivalents. These are testing the javascript engine itself and not node in any way, as far as I can tell. six-speed does a good job testing these things already, and there is a lot of overlap between these two suites. We also have alerts set up for six-speed on the V8 side so we will see any regressions before they make it into node. I'd suggest removing these benchmarks entirely.