test: remove common.fileExists()#22151
Closed
Trott wants to merge 2 commits intonodejs:masterfrom
Closed
Conversation
common.fileExists() can be replaced with fs.existsSync().
richardlau
approved these changes
Aug 6, 2018
starkwang
approved these changes
Aug 6, 2018
maclover7
approved these changes
Aug 6, 2018
targos
approved these changes
Aug 6, 2018
fesebuv
reviewed
Aug 6, 2018
fesebuv
left a comment
There was a problem hiding this comment.
Seems good to me, but I would advice to double check why some tests are failing.
Member
Author
lpinca
approved these changes
Aug 6, 2018
cjihrig
approved these changes
Aug 6, 2018
Member
|
Line 36 in a4c1cf5 |
Member
Author
BridgeAR
approved these changes
Aug 6, 2018
benjamingr
approved these changes
Aug 6, 2018
jasnell
approved these changes
Aug 6, 2018
trivikr
approved these changes
Aug 7, 2018
tniessen
approved these changes
Aug 7, 2018
fhinkel
approved these changes
Aug 8, 2018
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Aug 8, 2018
common.fileExists() can be replaced with fs.existsSync(). PR-URL: nodejs#22151 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
Member
Author
|
Landed in 41ae423 |
Contributor
|
Strangely, we have CI fails now due to this test: See #22104 (comment) |
3 tasks
Member
That test was added to the codebase in between the last CI for this PR (2 days ago) and it landing today. |
richardlau
added a commit
to richardlau/node-1
that referenced
this pull request
Aug 8, 2018
test-trace-event-promises.js was added to the codebase between the last CI for nodejs#22151 and it landing. Refs: nodejs#22151
2 tasks
Member
|
Fix for the additional test: #22200 |
MylesBorins
pushed a commit
that referenced
this pull request
Aug 8, 2018
test-trace-event-promises.js was added to the codebase between the last CI for #22151 and it landing. PR-URL: #22200 Refs: #22151 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
Member
Author
|
Oops! Add this to the list of reasons to get https://github.com/nodejs/commit-queue happening. @nodejs/commit-queue |
targos
pushed a commit
that referenced
this pull request
Aug 11, 2018
test-trace-event-promises.js was added to the codebase between the last CI for #22151 and it landing. PR-URL: #22200 Refs: #22151 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
targos
pushed a commit
that referenced
this pull request
Aug 11, 2018
common.fileExists() can be replaced with fs.existsSync(). PR-URL: #22151 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
This was referenced Aug 16, 2018
Contributor
firass111
pushed a commit
to firass111/Project_node1
that referenced
this pull request
Apr 16, 2025
test-trace-event-promises.js was added to the codebase between the last CI for nodejs/node#22151 and it landing. PR-URL: nodejs/node#22200 Refs: nodejs/node#22151 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
firass111
pushed a commit
to firass111/Project_node1
that referenced
this pull request
Apr 16, 2025
common.fileExists() can be replaced with fs.existsSync(). PR-URL: nodejs/node#22151 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
common.fileExists() can be replaced with fs.existsSync().
fs.existsSync()was undeprecated in Node.js 6.8.0.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes