src: add missing cmath include to traced_value.cc#21924
src: add missing cmath include to traced_value.cc#21924addaleax wants to merge 1 commit intonodejs:masterfrom
Conversation
maclover7
left a comment
maclover7
left a comment
There was a problem hiding this comment.
LGTM, but is there a test we could add here to make sure this doesn't break? Or maybe there was a warning that was missed in CI somewhere?
maclover7
added
c++
|
@maclover7 I don't know. My guess that this went undetected because |
|
CI failures are both known flakes, and it’s not like this change would have interacted with them in some way, but: OS X re-build: https://ci.nodejs.org/job/node-test-commit-osx/19964/ |
|
Landed in 2db74f2 |
Fixes: #21903 PR-URL: #21924 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Fixes: #21903 PR-URL: #21924 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]>
8 participants
Fixes: #21903
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes