test, bechmark: use new Buffer API where appropriate#18980
Closed
ChALkeR wants to merge 1 commit intonodejs:masterfrom
Closed
test, bechmark: use new Buffer API where appropriate#18980ChALkeR wants to merge 1 commit intonodejs:masterfrom
ChALkeR wants to merge 1 commit intonodejs:masterfrom
Conversation
ChALkeR
added
test
nodejs-github-bot
added
async_hooks
cjihrig
approved these changes
Feb 24, 2018
Contributor
There was a problem hiding this comment.
Maybe write this as "Tests the deprecated Buffer() constructor"
If you don't change it, "on a purpose" should be "on purpose"
Member
Author
There was a problem hiding this comment.
Technically, the first line of those two (Buffer(100)) is not a constructor call by itself, it's the commit description which is a bit inaccurate there (but rewording will make it needlessly longer).
I will fix the language though, thanks!
For tests / benchmarks that are creating Buffer instances for any reason other than to test Buffer constructor, use the new Buffer.alloc/Buffer.from API instead of the deprecated API.
ChALkeR
force-pushed
the
buffer-usage-cleanup
branch
from
be71228 to
bc15526
Compare
watilde
approved these changes
Feb 24, 2018
BridgeAR
approved these changes
Feb 24, 2018
lpinca
approved these changes
Feb 24, 2018
jasnell
approved these changes
Feb 26, 2018
BridgeAR
approved these changes
Mar 1, 2018
Member
BridgeAR
left a comment
BridgeAR
left a comment
There was a problem hiding this comment.
LGTM. We might actually introduce a linting rule so it does not sneak back in at some point.
BridgeAR
added
the
author ready
Member
|
@ChALkeR please always start a CI after opening a PR :-) |
tniessen
approved these changes
Mar 4, 2018
Contributor
|
Landed in 8ed44ff |
apapirovski
pushed a commit
that referenced
this pull request
Mar 4, 2018
For tests / benchmarks that are creating Buffer instances for any reason other than to test Buffer constructor, use the new Buffer.alloc/Buffer.from API instead of the deprecated API. PR-URL: #18980 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Mar 5, 2018
For tests / benchmarks that are creating Buffer instances for any reason other than to test Buffer constructor, use the new Buffer.alloc/Buffer.from API instead of the deprecated API. PR-URL: nodejs#18980 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Merged
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
For tests / benchmarks that are creating Buffer instances for any reason other than to test Buffer constructor, use the new Buffer.alloc/Buffer.from API instead of the deprecated API. PR-URL: nodejs#18980 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Member
|
If this needs to be backported to 8.x, a separate backport PR will be necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For tests / benchmarks that are creating Buffer instances for any reason other than to test Buffer constructor, use the new
Buffer.alloc/Buffer.fromAPI instead of the deprecated API.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test, benchmark