Skip to content

n-api: remove extra reference from test#18542

Closed
gabrielschulhof wants to merge 1 commit intonodejs:masterfrom
gabrielschulhof:addons-napi-cleanup
Closed

n-api: remove extra reference from test#18542
gabrielschulhof wants to merge 1 commit intonodejs:masterfrom
gabrielschulhof:addons-napi-cleanup

Conversation

@gabrielschulhof
Copy link
Copy Markdown
Contributor

@gabrielschulhof gabrielschulhof commented Feb 3, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

n-api

@nodejs-github-bot nodejs-github-bot added dont-land-on-v4.x node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. labels Feb 3, 2018
mhdawson
mhdawson approved these changes Feb 5, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Copy Markdown
Member

mhdawson commented Feb 5, 2018

CI run: https://ci.nodejs.org/job/node-test-pull-request/12960/

@gabrielschulhof
Copy link
Copy Markdown
Contributor Author

gabrielschulhof commented Feb 6, 2018 •
edited
Loading

https://ci.nodejs.org/job/node-test-commit-arm/13651/nodes=ubuntu1604-arm64_odroid_c2/consoleFull fails in the same way as other builds, such as

https://ci.nodejs.org/job/node-test-commit-arm/13649/nodes=ubuntu1604-arm64_odroid_c2/consoleFull

and

https://ci.nodejs.org/job/node-test-commit-arm/13649/nodes=ubuntu1604-arm64_odroid_c2/consoleFull

I don't think the fact that deps/openssl/openssl/crypto/x509v3/v3_purp.c sometimes fails to compile is an error related to this change. In fact, it seems like the file gets corrupted, because there are stray characters in the input in these builds, whereas in builds like

https://ci.nodejs.org/job/node-test-commit-arm/13650/nodes=ubuntu1604-arm64_odroid_c2/consoleFull

the same file compiles just fine.

../deps/openssl/openssl/crypto/x509v3/v3_purp.c: In function ‘X509_check_akid’:
../deps/openssl/openssl/crypto/x509v3/v3_purp.c:844:7: error: expected expression before ‘if’
   !   (     if&*gen->type == GEN_DIRNAME) {
       ^
../deps/openssl/openssl/crypto/x509v3/v3_purp.c:844:27: error: expected ‘;’ before ‘{’ token
   !   (     if&*gen->type == GEN_DIRNAME) {
                           ^
../deps/openssl/openssl/crypto/x509v3/v3_purp.c:845:7: error: stray ‘\240’ in program
       �       $ nm = gen->d.dipn;
       ^
../deps/openssl/openssl/crypto/x509v3/v3_purp.c:847:7: error: stray ‘`’ in program
       `     }
       ^

@gabrielschulhof
Copy link
Copy Markdown
Contributor Author

gabrielschulhof commented Feb 6, 2018

Landed in d379db3.

gabrielschulhof pushed a commit that referenced this pull request Feb 6, 2018
n-api: remove extra reference from test
d379db3 
PR-URL: #18542
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@gabrielschulhof gabrielschulhof deleted the addons-napi-cleanup branch February 6, 2018 01:52
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@MylesBorins
n-api: remove extra reference from test
cf588e0 
PR-URL: #18542
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@MylesBorins
n-api: remove extra reference from test
232ea3e 
PR-URL: #18542
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@MylesBorins
n-api: remove extra reference from test
9c818cf 
PR-URL: #18542
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 21, 2018
Merged
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 12, 2018
n-api: remove extra reference from test
01b28fa 
PR-URL: nodejs#18542
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 16, 2018
n-api: remove extra reference from test
d75fbeb 
PR-URL: nodejs#18542
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 16, 2018
@MylesBorins
n-api: remove extra reference from test
516c287 
Backport-PR-URL: #19447
PR-URL: #18542
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Apr 16, 2018
Merged
MylesBorins pushed a commit that referenced this pull request May 1, 2018
@MylesBorins
n-api: remove extra reference from test
9244e1d 
Backport-PR-URL: #19265
PR-URL: #18542
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins mentioned this pull request May 2, 2018
Merged
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@MayaLekova
n-api: remove extra reference from test
fd57785 
PR-URL: nodejs#18542
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes

+2 more reviewers

@TimothyGu TimothyGu TimothyGu approved these changes

@mhdawson mhdawson mhdawson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gabrielschulhof @mhdawson @TimothyGu @cjihrig @nodejs-github-bot