build: add c++ coverage support on macOS#16163
Conversation
nodejs-github-bot
added
the
build
jasnell
left a comment
jasnell
left a comment
There was a problem hiding this comment.
rubber stampy LGTM. Looked it over, didn't see anything that was problematic, but cannot test on macos at the moment.
There was a problem hiding this comment.
Tiniest of nits: two space indent like the lines above.
|
I am still seeing 0% C++ Coverage with this patch on MacOS 10.12.4... |
|
@joyeecheung That was happening to me before too. I had to completely remove the |
evanlucas
force-pushed
the
macos-src-coverage
branch
from
acb5cb3 to
d261d72
Compare
mhdawson
left a comment
mhdawson
left a comment
There was a problem hiding this comment.
LGTM, good to see this get added.
|
ping @joyeecheung, did you get a chance to try this again? |
|
@evanlucas I have tried before with |
|
@joyeecheung are you using ccache by chance? |
|
@evanlucas No, I don't have ccache set up. I tried again but still no luck :( Maybe this has something to do with the version of llvm toolchain that I am using? |
|
@joyeecheung it very well could: Ah, are you using Xcode's cli tools or did you manually install everything? |
|
@evanlucas Ah, I seemed to forget to rerun |
|
@joyeecheung awesome thanks! I'll land today then! Thanks! |
macOS requires passing the --coverage flag in OTHER_LDFLAGS and OTHER_CFLAGS in xcode_settings. PR-URL: nodejs#16163 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
evanlucas
force-pushed
the
macos-src-coverage
branch
from
d261d72 to
a078584
Compare
|
Landed in a078584. Thanks! |
macOS requires passing the --coverage flag in OTHER_LDFLAGS and OTHER_CFLAGS in xcode_settings. PR-URL: #16163 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
macOS requires passing the --coverage flag in OTHER_LDFLAGS and OTHER_CFLAGS in xcode_settings. PR-URL: nodejs/node#16163 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
|
Should this be backported to |
|
Not really necessary IMO, so I'll add the label |
macOS requires passing the --coverage flag in OTHER_LDFLAGS and OTHER_CFLAGS in xcode_settings. PR-URL: nodejs/node#16163 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
11 participants
macOS requires passing the --coverage flag in OTHER_LDFLAGS and
OTHER_CFLAGS in xcode_settings.
Checklist
Affected core subsystem(s)
build