src: use maybe versions of methods#16005
Closed
boutell wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
nodejs-github-bot
added
c++
bnoordhuis
approved these changes
Oct 6, 2017
targos
added
the
code-and-learn
targos
approved these changes
Oct 6, 2017
cjihrig
approved these changes
Oct 7, 2017
TimothyGu
approved these changes
Oct 7, 2017
Member
TimothyGu
left a comment
TimothyGu
left a comment
There was a problem hiding this comment.
This commit looks good.
I commented on two nits, but there's no need to fix them -- we can handle them while landing this PR -- but if you can fix them that'd be even better!
Member
There was a problem hiding this comment.
nit: we would generally write it this way:
Local<Value> emit_fn =
process_object->Get(context, FIXED_ONE_BYTE_STRING(isolate, "emit"))
.ToLocalChecked();
addaleax
approved these changes
Oct 7, 2017
jasnell
approved these changes
Oct 9, 2017
Member
|
@boutell would you be so kind and please rebase? This contains conflicts at the moment |
Member
|
Hi, everyone! I rebased to get rid of the merge conflict, and I also took care of @TimothyGu's nits while I was in there. This should be good to go. PTAL. |
bnoordhuis
approved these changes
Oct 27, 2017
| Local<Object> process_object = parent_env_->process_object(); | ||
| Local<Value> emit_fn = | ||
| process_object->Get(FIXED_ONE_BYTE_STRING(isolate, "emit")); | ||
| process_object->Get(context, FIXED_ONE_BYTE_STRING(isolate, "emit")) |
Member
There was a problem hiding this comment.
Micro-nit: indent by 4 spaces (line continuation)
Member
|
Landed in 2e8c04b, thank you! 🎉 |
tniessen
pushed a commit
that referenced
this pull request
Oct 28, 2017
PR-URL: #16005 Fixes: #15864 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
gibfahn
pushed a commit
that referenced
this pull request
Oct 30, 2017
PR-URL: #16005 Fixes: #15864 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
gibfahn
pushed a commit
that referenced
this pull request
Oct 30, 2017
PR-URL: #16005 Fixes: #15864 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
gibfahn
pushed a commit
that referenced
this pull request
Oct 31, 2017
PR-URL: #16005 Fixes: #15864 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
Qard
pushed a commit
to ayojs/ayo
that referenced
this pull request
Nov 2, 2017
PR-URL: nodejs/node#16005 Fixes: nodejs/node#15864 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Qard
pushed a commit
to ayojs/ayo
that referenced
this pull request
Nov 2, 2017
PR-URL: nodejs/node#16005 Fixes: nodejs/node#15864 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
PR-URL: nodejs/node#16005 Fixes: nodejs/node#15864 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invoke newer "maybe" versions of methods for which the old versions have been deprecated, throughout inspector_agent.cc.
Tests exist in test-inspector.js and are passing. If these tests are not sufficiently relevant let me now where I might begin supplying more specific coverage.
Affected core subsystems: inspector.
Implements #15864.