test: update common.fixturesDir usage with fixtures.fixturesDir#15874
Closed
alvaro450 wants to merge 1 commit intonodejs:masterfrom
Closed
test: update common.fixturesDir usage with fixtures.fixturesDir#15874alvaro450 wants to merge 1 commit intonodejs:masterfrom
alvaro450 wants to merge 1 commit intonodejs:masterfrom
Conversation
Trott
added
the
code-and-learn
Member
|
Hi, @alvaro450! Welcome and thanks for this! Can you update this to use |
jasnell
reviewed
Oct 10, 2017
| key: fs.readFileSync(`${common.fixturesDir}/keys/agent2-key.pem`), | ||
| cert: fs.readFileSync(`${common.fixturesDir}/keys/agent2-cert.pem`), | ||
| key: fs.readFileSync(`${fixtures.fixturesDir}/keys/agent2-key.pem`), | ||
| cert: fs.readFileSync(`${fixtures.fixturesDir}/keys/agent2-cert.pem`), |
Member
There was a problem hiding this comment.
This can be:
key: fixtures.readKey('agent2-key.pem'),
cert: fixtures.readKey('agent2-cert.pem')
Member
There was a problem hiding this comment.
I will fix this while landing.
BridgeAR
approved these changes
Oct 18, 2017
| key: fs.readFileSync(`${common.fixturesDir}/keys/agent2-key.pem`), | ||
| cert: fs.readFileSync(`${common.fixturesDir}/keys/agent2-cert.pem`), | ||
| key: fs.readFileSync(`${fixtures.fixturesDir}/keys/agent2-key.pem`), | ||
| cert: fs.readFileSync(`${fixtures.fixturesDir}/keys/agent2-cert.pem`), |
Member
There was a problem hiding this comment.
I will fix this while landing.
BridgeAR
pushed a commit
that referenced
this pull request
Oct 19, 2017
PR-URL: #15874 Reviewed-By: Ruben Bridgewater <[email protected]>
Member
|
Landed in b096533 Thanks for the PR, and congratulations on becoming a Node.js Contributor 🎉 ! |
MylesBorins
pushed a commit
that referenced
this pull request
Oct 23, 2017
PR-URL: #15874 Reviewed-By: Ruben Bridgewater <[email protected]>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 26, 2017
PR-URL: nodejs/node#15874 Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2017
PR-URL: #15874 Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 21, 2017
PR-URL: #15874 Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
PR-URL: #15874 Reviewed-By: Ruben Bridgewater <[email protected]>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
PR-URL: nodejs/node#15874 Reviewed-By: Ruben Bridgewater <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)